Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI accessibility - Focus on screen reader support #8835

Merged
merged 23 commits into from
Dec 7, 2021

Conversation

mbrzakovic
Copy link
Collaborator

Goes one step forward towards a vision shared in #7713.
This change implements several accessibility principles with the focus on improving screen reader support.
Additionally, few UI inconsistencies have been addressed as well.

Changes:

  • Ensures elements have discerniable text - Provided missing titles and aria-label to several items (mostly buttons) + missing tooltip added for add tags [fef933a - 094ace6]

image

  • More descriptive titles 10fad14 02e92d9
  • Few image alts added a77840e
  • Button role added where appropriate 4bee356 50de029 0413320
  • Ensure states are being announced - aria-selected/disabled/expanded/pressed etc. e91dc1b 6337e4d
  • Polish up the headings (this impacts the speed at which assistive technologies allow people to orient around locations on page) 30ef0b8 8eba5db. Additionally, keyboard shortcuts heading has been centered, and sidebar headings have been increased, making the ui better looking and more intuitive.

image

@mbrzakovic mbrzakovic added the accessibility Relates to personal ability or assistive tools label Dec 2, 2021
Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request. These are certainly good improvements. I've got only one question/comment, see below.

PS: I've fixed the merge conflicts caused by other changes in the development branch. Also, I've added a line to the changelog to this branch (see 960f576). Feel free to amend it if you think something should be mentioned more specifically.

modules/ui/sections/background_offset.js Outdated Show resolved Hide resolved
@mbrzakovic mbrzakovic requested a review from tyrasd December 7, 2021 16:17
@tyrasd tyrasd merged commit 68b6d9f into develop Dec 7, 2021
@tyrasd tyrasd deleted the accessible_ui branch December 7, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Relates to personal ability or assistive tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants