Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a preset for barrier=entrance but you cannot find it via search #9913

Open
Openstreetmapler opened this issue Sep 22, 2023 · 7 comments
Labels
id-tagging-schema An issue related to the id-tagging-schema repo

Comments

@Openstreetmapler
Copy link

URL

No response

How to reproduce the issue?

In German locale:

  1. Select a node where a highway crosses a linear barrier and there’s a gap in the barrier (barrier=entrance by definition).
  2. Search for the preset Durchgang.
  3. It won’t show up, you have to manually add barrier=entrance!
  4. When you did that, the preset Durchgang will show up at the top.

Screenshot(s) or anything else?

This might or might not happen in English or other locales.

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit, Development version at ideditor.netlify.app

What version numbers does this issue effect?

2.27.1, 2.28.0-dev

Which browsers are you seeing this problem on?

Firefox

@k-yle
Copy link
Collaborator

k-yle commented Sep 24, 2023

This preset was intentionally made unsearchable 10 years ago in f549e28. At the time, the wiki page seemed to suggest using entrance=* instead of barrier=entrance

@Openstreetmapler
Copy link
Author

This preset was intentionally made unsearchable 10 years ago in f549e28. At the time, the wiki page seemed to suggest using entrance=* instead of barrier=entrance

But now, the wiki page says:

Unlike a barrier=entrance, an entrance=* might be (and generally is) secured by a door, gate or other means.

I interpret this as an obligation to make the barrier=entrance preset searchable again.

@Openstreetmapler
Copy link
Author

Why are you not interested in fixing this?!

@k-yle
Copy link
Collaborator

k-yle commented Oct 9, 2023

just to be clear, I'm not a maintainer of iD.

In #9913 (comment) I just wanted to provide some background information.

It will be up to @tyrasd to make a decision

@tordans
Copy link
Collaborator

tordans commented Oct 9, 2023

One think we need to figure out is, how to make sure user don't select the wrong "entrance" if both were searchable.

Right now, barrier=entrance is a power user feature and I expect those users to know what they are doing. Once both become searchable we might have an issue with miss-tagging because we do not guide people to the right preset well enough.

ATM, the distiction is not good enough IMO

A B
Bildschirmfoto 2023-10-09 um 21 26 01 Bildschirmfoto 2023-10-09 um 21 26 12

The situation is a bit better when using the German translation with "Durchgang" and "Eingang / Ausgang", but I am still confused whenever I see those preset values.

I am not sure, we have the proper tooling to make this tagging work / usable.

  • A possible limitation could be that barrier=entrance is only allowed as a node on a barrier=* way. But we don't have this kind of conditioning, yet (AFAIK)
  • Or, we could consider both variants of the same and name one "Entrance/Exit with door" and one "Entrance/Exit without door" … accepting the fact, that there will be barrier=entrance on non-barrier=* ways/areas where there is no door.

@Dimitar5555
Copy link
Contributor

A possible limitation could be that barrier=entrance is only allowed as a node on a barrier=* way. But we don't have this kind of conditioning, yet (AFAIK)

It's tracked in ideditor/schema-builder#96.

@Openstreetmapler
Copy link
Author

Openstreetmapler commented Oct 12, 2023

One think we need to figure out is, how to make sure user don't select the wrong "entrance" if both were searchable.

Right now, barrier=entrance is a power user feature and I expect those users to know what they are doing. Once both become searchable we might have an issue with miss-tagging because we do not guide people to the right preset well enough.

I just had an idea: What about user-defined presets? That way, I can add/edit the barrier=entrance preset for my own use and this information will be tied to my OSM account, i. e. the default behaviour for less-experienced users won’t be affected.

@tordans tordans added the id-tagging-schema An issue related to the id-tagging-schema repo label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
id-tagging-schema An issue related to the id-tagging-schema repo
Projects
None yet
Development

No branches or pull requests

4 participants