You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here's another one which has irked me for a while: when two adjacent ways are being merged, iD validation would not let me do that if they belong to different relations (so far, so good, although I don't quite like this). However, for the two sets relations to match, iD requires them to be in the same order on the object as well, which is simply wrong: this order is basically arbitrary and should not matter anywhere.
As a simplest example, let's create two consecutive paths and assign them to two hiking route relations: the first one to routes {A, B} and the second one to routes {B, A}. When I select them and try to [C]ombine them, I get:
"These features can't be merged since they belong to conflicting relations"
For simple cases it's just annoying (need to reassign relations in the same order), but for highways featuring a high number of e.g. bus route relations this makes merging nigh impossible.
The fix seems to be simple: internally set the relation sets by name or ID, so that they will match when compared. I wouldn't mind having that sorted in the UI as well -- at least it would make the relation order predictable.
The text was updated successfully, but these errors were encountered:
re: #1389
re: openstreetmap/iD#10089
re: openstreetmap/iD#9502
re: openstreetmap/iD#9788
This was tricky to track down, as iD#10089 doesn't actually fix the issue
properly - really we should just not be using utilArrayIdentical with objects.
I wrote some tests to actually cover this issue and ensure that's it is fixed
correctly by comparing relation IDs.
Here's another one which has irked me for a while: when two adjacent ways are being merged, iD validation would not let me do that if they belong to different relations (so far, so good, although I don't quite like this). However, for the two sets relations to match, iD requires them to be in the same order on the object as well, which is simply wrong: this order is basically arbitrary and should not matter anywhere.
As a simplest example, let's create two consecutive paths and assign them to two hiking route relations: the first one to routes {A, B} and the second one to routes {B, A}. When I select them and try to [C]ombine them, I get:
"These features can't be merged since they belong to conflicting relations"
For simple cases it's just annoying (need to reassign relations in the same order), but for highways featuring a high number of e.g. bus route relations this makes merging nigh impossible.
The fix seems to be simple: internally set the relation sets by name or ID, so that they will match when compared. I wouldn't mind having that sorted in the UI as well -- at least it would make the relation order predictable.
The text was updated successfully, but these errors were encountered: