Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouped fields #8104

Open
quincylvania opened this issue Oct 19, 2020 · 5 comments
Open

Grouped fields #8104

quincylvania opened this issue Oct 19, 2020 · 5 comments
Labels
field An issue with a field in the user interface priority A top priority issue that has a big impact or matter most to new mappers

Comments

@quincylvania
Copy link
Collaborator

iD has a few special fields that group related tags together, like Name, Address, Structure, Allowed Access, and Bike Lanes. Grouping is a nice way to make the inspector simpler and more intuitive. There are a lot more tags that could benefit from grouping, for example:

Instead of coding a special field type for every grouping, we should look into a reusable grouped field type that can handle simple combinations.

@quincylvania quincylvania added the field An issue with a field in the user interface label Oct 19, 2020
@karmanya007
Copy link
Contributor

@quincylvania Hey, I want to start contributing to this project. Could you guide me a bit more on this issue. Would love to start off somewhere.

@quincylvania
Copy link
Collaborator Author

Welcome, @karmanya007. This issue is actually a bit advanced, and there aren't that many introductory issues open right now. But if you're feeling intrepid then can read our contributing guide and jump in anywhere.

@maro-21
Copy link

maro-21 commented Oct 21, 2020

Instead of coding a special field type for every grouping, we should look into a reusable grouped field type that can handle simple combinations.

We already have such fields - like operator and operator:type for schools. Can't we use the same for the ones above? If a user fills in the first field, other appear below it.

@quincylvania
Copy link
Collaborator Author

We already have such fields - like operator and operator:type for schools.

@maro-21 Yes, these already work such that one field's appearance depends on a related field's value, but they should also be grouped together visually.

@karmanya007
Copy link
Contributor

@quincylvania I think, now I can take this one. Could you tell me how the grouping happens?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
field An issue with a field in the user interface priority A top priority issue that has a big impact or matter most to new mappers
Projects
None yet
Development

No branches or pull requests

4 participants