Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name autocomplete makes it hard to enter names that start with common words #5558

Closed
iandees opened this issue Dec 5, 2018 · 1 comment
Closed

Comments

@iandees
Copy link
Collaborator

iandees commented Dec 5, 2018

There's a place nearby called "We Are Nuts". When I try to type "We" + space into the name field, it autocompletes to a store called "WE - somethingsomething", capitalizes the e for me, and it's hard to go back and fix that incorrect capitalization:

nameautocompletebug

@bhousel
Copy link
Member

bhousel commented Dec 7, 2018

Scope creeping on this issue (#5568 is related)...

  • fix keyboard handling of up/down arrow and escape when a combobox is open (these keys should not do other iD things like trying to pan the screen or return to browse mode)
  • escape should get rid of whatever autocompletion selected text is there
  • up/down key navigation seems to not class the top item as selected if the list is too long / or scroll the item into view / or something
  • this means that tabbing out of the list with the wrong item selected can accept an item that is not the one selected/displayed in the input field

I've added an option to disable autocomplete behavior.. I might keep it or get rid of it depending on how the combobox "feels" after I make it do all the things that I expect a combobox to do. We could also start out autocompleting and then maybe put the combo into "no autocomplete" mode after the user starts backspacing or something.

@bhousel bhousel closed this as completed in d574bfc Dec 7, 2018
@bhousel bhousel removed the wip Work in progress label Dec 10, 2018
bhousel added a commit that referenced this issue Feb 12, 2021
This has caused problems going back a long time, and now that we have a validator
and very visible brand presets with logos, it's not necessary anymore.
(re: #5558, closes #8271, closes #8304)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants