-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add captcha to resource form if set to everyone #427
Open
LorenzoJokhan
wants to merge
10
commits into
development
Choose a base branch
from
feature/add-captcha-to-resource-form-if-set-to-everyone
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/add captcha to resource form if set to everyone #427
LorenzoJokhan
wants to merge
10
commits into
development
from
feature/add-captcha-to-resource-form-if-set-to-everyone
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudivanhierden
requested changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small changes, other than that it's good to go!
packages/cms/lib/modules/resource-form-widgets/views/includes/fields/captcha.html
Outdated
Show resolved
Hide resolved
packages/cms/lib/modules/resource-form-widgets/views/includes/static-article-form.html
Outdated
Show resolved
Hide resolved
Co-authored-by: Rudi van Hierden <[email protected]>
…fields/captcha.html Co-authored-by: Rudi van Hierden <[email protected]>
…static-article-form.html Co-authored-by: Rudi van Hierden <[email protected]>
…if-set-to-everyone
rudivanhierden
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include
Issue reference
Fixes # (issue)
Type of change
Is it a new feature, bug fix, code improvement, etc.
If it is a breaking change what needs to be done to fix that
Documentation
Is the documentation updated, maybe a link
Tests
(How) has the change been tested
Branch
If the branch to merge to is not development