This repository was archived by the owner on Sep 9, 2025. It is now read-only.
Added length check for checking if there are any users left on the si…#294
Merged
LorenzoJokhan merged 1 commit intodevelfrom Mar 7, 2023
Merged
Conversation
…de - [] is truthy
LorenzoJokhan
pushed a commit
that referenced
this pull request
Apr 20, 2023
* render concept templates for idea when creating or when changed from concept to published * Added concept templates * Add check on existing users bofore deleting a site * Changed mail implementation to allow changing the email in the admin panel * Added a migration to add type column and exposed it * Rework classes to anonymize users in the background (#292) * Rework classes to anonymize users in the background * remove console.log statement * Remove task code which does not really seem usefull in any way * Remove the do check inside method doAnonymizeAllUsers, it will always be in 'do' replace req param with self * Remove dangling console log statement * Added length check for checking if there are any users left on the side - [] is truthy (#294) * Added type field when creating a tag (#295) * Feature/add conceptmail and concept topublished config (#296) * Added conceptMail and conceptToPublishedEmail config * Remove accidental .env --------- Co-authored-by: Niels Vegter <niels@denes.nl>
LorenzoJokhan
pushed a commit
that referenced
this pull request
May 5, 2023
* render concept templates for idea when creating or when changed from concept to published * Added concept templates * Add check on existing users bofore deleting a site * Changed mail implementation to allow changing the email in the admin panel * Added a migration to add type column and exposed it * Rework classes to anonymize users in the background (#292) * Rework classes to anonymize users in the background * remove console.log statement * Remove task code which does not really seem usefull in any way * Remove the do check inside method doAnonymizeAllUsers, it will always be in 'do' replace req param with self * Remove dangling console log statement * Added length check for checking if there are any users left on the side - [] is truthy (#294) * Added type field when creating a tag (#295) * Feature/add conceptmail and concept topublished config (#296) * Added conceptMail and conceptToPublishedEmail config * Remove accidental .env * Added new regex to also support {ideaId} format used in global url& api instellingen slug setting (#300) --------- Co-authored-by: Niels Vegter <niels@denes.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…de - [] is truthy
Description
Please include
Issue reference
Fixes # (issue)
Type of change
Is it a new feature, bug fix, code improvement, etc.
If it is a breaking change what needs to be done to fix that
Documentation
Is the documentation updated, maybe a link
Tests
(How) has the change been tested
Branch
If the branch to merge to is not development