-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Aodh rock definitions #31
Conversation
- sudo | ||
- aodh-api | ||
- aodh-evaluator | ||
- aodh-expirer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package is not mentioned in any of the other aodh services. Is this package comes as a dependency from some other package? If so, do we need to mention the package explicitly here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit inline. Other than that PR looks good, thanks!
rocks/aodh-api/README.md
Outdated
> docker save aodh-api:2023.1 > ./aodh-api_2023.1.tar | ||
> microk8s ctr image import ./aodh-api_2023.1.tar | ||
# Try with sunbeam | ||
> juju attach-resource aodh-api aodh-api-image=aodh-api:2023.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change this to ``juju attach-resource aodh-k8s aodh-api-image=aodh-api:2023.1
README for other aodh rocks also should be changed just to make it consistent across READMEs of same component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
No description provided.