Combine heat-api and heat-api-cfn rocks #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make single rock for heat-api and heat-api-cfn. In the process of making single charm for heat-api and heat-api-cfn, the metadata yaml for the charm should hold only heat-api container and can act as heat-api service or heat-api-cfn service based on configuration parameter. However the container to resource mapping is static in metadata.yaml. So the heat-api-image resource should hold packages for both heat-api and heat-api-cfn. Removed heat-api-cfn rock and added heat-api-cfn package in heat-api rock. Ignore github workflow action to build rock if the rock is deleted.
gnuoy
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make single rock for heat-api and heat-api-cfn.
In the process of making single charm for heat-api and heat-api-cfn, the metadata yaml for the charm
should hold only heat-api container and can act as heat-api service or heat-api-cfn service based on
configuration parameter. However the container to
resource mapping is static in metadata.yaml. So
the heat-api-image resource should hold packages
for both heat-api and heat-api-cfn.
Removed heat-api-cfn rock and added heat-api-cfn
package in heat-api rock.