Skip to content

Conversation

@kstrenkova
Copy link
Contributor

@kstrenkova kstrenkova commented Oct 7, 2025

This patch removes duplicate code from common controller functions. In the future the code will be easier to maintain thanks to these small changes.

This patch includes:

  • GetContainerImage function refactor
  • GetPodName function refactor
  • Functions moved thanks to being Tempest specific

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/076a80d3d7ab4b4383ac90d4943221ca

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 20m 07s
podified-multinode-edpm-deployment-crc-test-operator FAILURE in 2h 08m 52s

@kstrenkova kstrenkova force-pushed the refactor-reconciler-functions branch from c464864 to fc233fb Compare October 8, 2025 12:18
@kstrenkova kstrenkova force-pushed the refactor-reconciler-functions branch 3 times, most recently from 26afe9a to d36fbd5 Compare October 9, 2025 09:44
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/35b41a4a32514af5ac78622f13a1f687

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 32m 37s
podified-multinode-edpm-deployment-crc-test-operator FAILURE in 1h 16m 50s

@kstrenkova kstrenkova force-pushed the refactor-reconciler-functions branch 2 times, most recently from 3b86ae5 to d364979 Compare October 14, 2025 12:23
@kstrenkova kstrenkova force-pushed the refactor-reconciler-functions branch from d364979 to 7b31bb9 Compare October 15, 2025 12:22
@kstrenkova
Copy link
Contributor Author

To summarize why I think the patch is okay to merge:

  • GetPodName function is working the same as before, you can check that the names are correctly staying the same.
  • GetContainerImage function I tested locally and tried all the returns. They were successful.
  • Other functions are just moved as Tempest specific or the code from them is used directly and they are removed.

@kstrenkova kstrenkova force-pushed the refactor-reconciler-functions branch 2 times, most recently from 15b333e to 3e7cf3d Compare October 29, 2025 08:57
@kstrenkova
Copy link
Contributor Author

/retest

This patch removes duplicate code from common controller functions.
In the future the code will be easier to maintain thanks to these
small changes.

This patch includes:
- GetContainerImage function refactor
- GetPodName function refactor
- Functions moved thanks to being Tempest specific
@kstrenkova kstrenkova force-pushed the refactor-reconciler-functions branch from 3e7cf3d to 5ad106f Compare October 29, 2025 14:56
@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianfusco, kstrenkova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e4cbde8 into openstack-k8s-operators:main Oct 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants