-
Notifications
You must be signed in to change notification settings - Fork 33
Refactor common controller functions #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor common controller functions #351
Conversation
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/076a80d3d7ab4b4383ac90d4943221ca ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 20m 07s |
c464864 to
fc233fb
Compare
26afe9a to
d36fbd5
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/35b41a4a32514af5ac78622f13a1f687 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 32m 37s |
3b86ae5 to
d364979
Compare
d364979 to
7b31bb9
Compare
|
To summarize why I think the patch is okay to merge:
|
15b333e to
3e7cf3d
Compare
|
/retest |
This patch removes duplicate code from common controller functions. In the future the code will be easier to maintain thanks to these small changes. This patch includes: - GetContainerImage function refactor - GetPodName function refactor - Functions moved thanks to being Tempest specific
3e7cf3d to
5ad106f
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianfusco, kstrenkova The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e4cbde8
into
openstack-k8s-operators:main
This patch removes duplicate code from common controller functions. In the future the code will be easier to maintain thanks to these small changes.
This patch includes: