Don't use baremetal-operator API in functional tests. #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 3, 2025
Merged
rabi
force-pushed
the
refactor_functional
branch
from
6ce9501 to
8f30033
Compare
fao89
approved these changes
Jan 3, 2025
bshephar
approved these changes
Jan 3, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar, fao89, rabi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We can't refactor baremetal-operator API as the tests fail when building openstack-operator with a baremetal-operator change. Signed-off-by: rabi <[email protected]>
rabi
force-pushed
the
refactor_functional
branch
from
8f30033 to
0f4edc7
Compare
|
New changes are detected. LGTM label has been removed. |
|
Had to be rebased as #1245 merged before this, we did not need that. |
|
/test openstack-operator-build-deploy-kuttl |
1 similar comment
|
/test openstack-operator-build-deploy-kuttl |
|
Kuttl failure unrelated: |
|
/test openstack-operator-build-deploy-kuttl |
openshift-merge-bot
bot
merged commit 800f323
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't refactor baremetal-operator API as the tests fail when building openstack-operator with a baremetal-operator change.