Update openstack module to use gophercloud v2 #645
+61
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate internal dependency from gophercloud v1.14.1 to v2.8.0. This updates the underlying OpenStack client library while maintaining backward compatibility with existing consumers. Changes: - Updated go.mod to use github.com/gophercloud/gophercloud/v2 v2.8.0 - Updated internal import paths to include /v2 suffix - Added context.Context parameter to internal gophercloud API calls - Fixed blockstorage services import path from blockstorage/extensions/services to blockstorage/v2/services All changes are internal implementation details. The public API of the openstack module remains unchanged and fully backward compatible. Files modified: openstack.go, user.go, project.go, service.go, role.go, endpoint.go, domain.go, limits.go, volume.go Jira: OSPRH-18162 Signed-off-by: Martin Schuppert <[email protected]> AssistedBy: cloude-4-sonnet
stuggi
added a commit
to stuggi/keystone-operator
that referenced
this pull request
Oct 1, 2025
Migrate keystone-operator from gophercloud v1 to v2 to align with the lib-common/modules/openstack migration. Changes: - Update api/go.mod to use gophercloud/v2 v2.8.0 - Update import paths in api/v1beta1/keystoneapi.go to use v2 - Update import paths in api/test/helpers/api.go to use v2 API paths (identity/v3/domains and identity/v3/users) - Run go mod tidy to update dependencies The keystone-operator uses gophercloud primarily for AuthScope types and identity v3 API structs (domains, users). No code changes were required beyond updating import paths, as the v2 API for these components remains compatible. Jira: OSPRH-18162 Depends-On: openstack-k8s-operators/lib-common#645 Signed-off-by: Martin Schuppert <[email protected]> AssistedBy: cloude-4-sonnet
stuggi
added a commit
to stuggi/keystone-operator
that referenced
this pull request
Oct 1, 2025
Migrate keystone-operator from gophercloud v1 to v2 to align with the lib-common/modules/openstack migration. The keystone-operator uses gophercloud primarily for AuthScope types and identity v3 API structs (domains, users). No code changes were required beyond updating import paths, as the v2 API for these components remains compatible. Jira: OSPRH-18162 Depends-On: openstack-k8s-operators/lib-common#645 Signed-off-by: Martin Schuppert <[email protected]> AssistedBy: cloude-4-sonnet
stuggi
added a commit
to stuggi/nova-operator
that referenced
this pull request
Oct 1, 2025
Migrate from gophercloud v1.14.1 to v2.8.0: - Update go.mod dependency and import paths - Add context parameters to API calls (List, Delete) - Handle DeleteResult return type from services.Delete() - Add Nova API version discovery endpoint in test fixture Gophercloud v2 requires context for all API operations and performs version discovery via GET / before other API calls. Updated test fixture to support this new behavior. Retained local Service struct in test fixture for test isolation and to avoid JSON marshalling complications with gophercloud v2's Service type. Jira: OSPRH-18162 Depends-On: openstack-k8s-operators/lib-common#645 Depends-On: openstack-k8s-operators/keystone-operator#635 Signed-off-by: Martin Schuppert <[email protected]> AssistedBy: cloude-4-sonnet
stuggi
added a commit
to stuggi/swift-operator
that referenced
this pull request
Oct 1, 2025
Update swift-operator to use gophercloud v2.8.0. Changes: - Update go.mod to use gophercloud/v2 v2.8.0 - Update import paths in pkg/swiftproxy/barbican.go to use v2 - Add context.Context parameter to Barbican API calls: - secrets.List().AllPages(ctx) - orders.Create(ctx, ...) Jira: OSPRH-18162 Depends-On: openstack-k8s-operators/lib-common#645 Depends-On: openstack-k8s-operators/keystone-operator#635 Signed-off-by: Martin Schuppert <[email protected]> AssistedBy: cloude-4-sonnet
stuggi
added a commit
to stuggi/nova-operator
that referenced
this pull request
Oct 1, 2025
Migrate from gophercloud v1.14.1 to v2.8.0: - Update go.mod dependency and import paths - Add context parameters to API calls (List, Delete) - Handle DeleteResult return type from services.Delete() - Add Nova API version discovery endpoint in test fixture Gophercloud v2 requires context for all API operations and performs version discovery via GET / before other API calls. Updated test fixture to support this new behavior. Retained local Service struct in test fixture for test isolation and to avoid JSON marshalling complications with gophercloud v2's Service type. Jira: OSPRH-18162 Depends-On: openstack-k8s-operators/lib-common#645 Depends-On: openstack-k8s-operators/keystone-operator#635 Signed-off-by: Martin Schuppert <[email protected]> AssistedBy: cloude-4-sonnet Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/glance-operator
that referenced
this pull request
Oct 1, 2025
Update glance-operator to use gophercloud v2.8.0. Changes: - Update go.mod to use gophercloud/v2 v2.8.0 - Update import path in controllers/glance_controller.go to use v2 The glance-operator only uses gophercloud.AuthScope type, so no API call changes were required (unlike operators that make direct gophercloud API calls which need context parameters). Jira: OSPRH-18162 Depends-On: openstack-k8s-operators/lib-common#645 Depends-On: openstack-k8s-operators/keystone-operator#635 AssistedBy: cloude-4-sonnet Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/swift-operator
that referenced
this pull request
Oct 1, 2025
Update swift-operator to use gophercloud v2.8.0. Changes: - Update go.mod to use gophercloud/v2 v2.8.0 - Update import paths in pkg/swiftproxy/barbican.go to use v2 - Add context.Context parameter to Barbican API calls: - secrets.List().AllPages(ctx) - orders.Create(ctx, ...) Jira: OSPRH-18162 Depends-On: openstack-k8s-operators/lib-common#645 Depends-On: openstack-k8s-operators/keystone-operator#635 AssistedBy: cloude-4-sonnet Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/keystone-operator
that referenced
this pull request
Oct 1, 2025
Migrate keystone-operator from gophercloud v1 to v2 to align with the lib-common/modules/openstack migration. The keystone-operator uses gophercloud primarily for AuthScope types and identity v3 API structs (domains, users). No code changes were required beyond updating import paths, as the v2 API for these components remains compatible. Jira: OSPRH-18162 Depends-On: openstack-k8s-operators/lib-common#645 Signed-off-by: Martin Schuppert <[email protected]> AssistedBy: cloude-4-sonnet
stuggi
added a commit
to stuggi/glance-operator
that referenced
this pull request
Oct 1, 2025
Update glance-operator to use gophercloud v2.8.0. Changes: - Update go.mod to use gophercloud/v2 v2.8.0 - Update import path in controllers/glance_controller.go to use v2 The glance-operator only uses gophercloud.AuthScope type, so no API call changes were required (unlike operators that make direct gophercloud API calls which need context parameters). Jira: OSPRH-18162 Depends-On: openstack-k8s-operators/lib-common#645 Depends-On: openstack-k8s-operators/keystone-operator#635 AssistedBy: cloude-4-sonnet Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/swift-operator
that referenced
this pull request
Oct 1, 2025
Update swift-operator to use gophercloud v2.8.0. Changes: - Update go.mod to use gophercloud/v2 v2.8.0 - Update import paths in pkg/swiftproxy/barbican.go to use v2 - Add context.Context parameter to Barbican API calls: - secrets.List().AllPages(ctx) - orders.Create(ctx, ...) Jira: OSPRH-18162 Depends-On: openstack-k8s-operators/lib-common#645 Depends-On: openstack-k8s-operators/keystone-operator#635 AssistedBy: cloude-4-sonnet Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/designate-operator
that referenced
this pull request
Oct 1, 2025
Update designate-operator to use gophercloud v2.8.0 Changes: - Update go.mod to use gophercloud/v2 v2.8.0 - Update import paths in tests/functional/api_fixture.go to use v2 - openstack/identity/v3/projects - openstack/identity/v3/users Jira: OSPRH-18162 Depends-On: openstack-k8s-operators/lib-common#645 Depends-On: openstack-k8s-operators/keystone-operator#635 AssistedBy: cloude-4-sonnet Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/keystone-operator
that referenced
this pull request
Oct 2, 2025
Migrate keystone-operator from gophercloud v1 to v2 to align with the lib-common/modules/openstack migration. The keystone-operator uses gophercloud primarily for AuthScope types and identity v3 API structs (domains, users). No code changes were required beyond updating import paths, as the v2 API for these components remains compatible. Jira: OSPRH-18162 Depends-On: openstack-k8s-operators/lib-common#645 Signed-off-by: Martin Schuppert <[email protected]> AssistedBy: cloude-4-sonnet
stuggi
added a commit
to stuggi/nova-operator
that referenced
this pull request
Oct 2, 2025
Migrate from gophercloud v1.14.1 to v2.8.0: - Update go.mod dependency and import paths - Add context parameters to API calls (List, Delete) - Handle DeleteResult return type from services.Delete() - Add Nova API version discovery endpoint in test fixture Gophercloud v2 requires context for all API operations and performs version discovery via GET / before other API calls. Updated test fixture to support this new behavior. Retained local Service struct in test fixture for test isolation and to avoid JSON marshalling complications with gophercloud v2's Service type. Jira: OSPRH-18162 Depends-On: openstack-k8s-operators/lib-common#645 Depends-On: openstack-k8s-operators/keystone-operator#635 AssistedBy: cloude-4-sonnet Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/swift-operator
that referenced
this pull request
Oct 2, 2025
Update swift-operator to use gophercloud v2.8.0. Changes: - Update go.mod to use gophercloud/v2 v2.8.0 - Update import paths in pkg/swiftproxy/barbican.go to use v2 - Add context.Context parameter to Barbican API calls: - secrets.List().AllPages(ctx) - orders.Create(ctx, ...) Jira: OSPRH-18162 Depends-On: openstack-k8s-operators/lib-common#645 Depends-On: openstack-k8s-operators/keystone-operator#635 AssistedBy: cloude-4-sonnet Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/designate-operator
that referenced
this pull request
Oct 2, 2025
Update designate-operator to use gophercloud v2.8.0 Changes: - Update go.mod to use gophercloud/v2 v2.8.0 - Update import paths in tests/functional/api_fixture.go to use v2 - openstack/identity/v3/projects - openstack/identity/v3/users Jira: OSPRH-18162 Depends-On: openstack-k8s-operators/lib-common#645 Depends-On: openstack-k8s-operators/keystone-operator#635 AssistedBy: cloude-4-sonnet Signed-off-by: Martin Schuppert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate internal dependency from gophercloud v1.14.1 to v2.8.0. This updates the underlying OpenStack client library while maintaining backward compatibility with existing consumers.
Changes:
All changes are internal implementation details. The public API of the openstack module remains unchanged and fully backward compatible.
Files modified: openstack.go, user.go, project.go, service.go, role.go, endpoint.go, domain.go, limits.go, volume.go
Jira: OSPRH-18162
AssistedBy: cloude-4-sonnet