Skip to content

Improve role #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Improve role #94

wants to merge 1 commit into from
+1 −1

Conversation

danpawlik
Copy link
Contributor

What improved:

  • run pre task after rhel subscription
  • remove kubernetes sysctl changes
  • remove cri-o bridge configuration file that forces to use just ipv4
  • remove temporary Ansible variable: enable_rhocp_subscription
  • remove variable firewalld_rules_permament variable
  • add microshift_version to the RHEL RHOCP subscription

morucci
morucci reviewed Jan 16, 2025
View reviewed changes
tasks/subscription.yaml
@@ -3,7 +3,7 @@
- name: Enable RHOCP repso
become: true
community.general.rhsm_repository:
name: "rhocp-4.16-for-rhel-9-{{ ansible_architecture }}-rpms"
name: "rhocp-{{ microshift_version }}-for-rhel-9-{{ ansible_architecture }}-rpms"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO we should avoid this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but we still need to versioning that, so maybe we can go with that now?
Full url will require to do additional step on changing version.

@danpawlik
Call microshift_version variable when enabling RHEL RHOCP subscription
c44f1ef 
The RHOCP version that would be installed on RHEL should be same as
in microshift_version var.
@danpawlik danpawlik force-pushed the improve-rhel-and-remove-leftovers branch from 6d8be50 to c44f1ef Compare January 16, 2025 15:24
@morucci
Copy link
Collaborator

morucci commented Feb 17, 2025

What improved:

* run pre task after rhel subscription

* remove kubernetes sysctl changes

* remove cri-o bridge configuration file that forces to use just ipv4

* remove temporary Ansible variable: enable_rhocp_subscription

* remove variable firewalld_rules_permament variable

* add microshift_version to the RHEL RHOCP subscription

The PR initial message does not match the changes introduced by that Pull Request.

@danpawlik danpawlik closed this Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morucci morucci morucci left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danpawlik @morucci