-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the NIST CAVS test vectors for CCM #8981
Conversation
# https://www.openssl.org/source/license.html | ||
|
||
#Convert CAVS test vectors to a format suitable for evp_test | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add 'use strict; use warnings' ?
{ | ||
chomp; | ||
|
||
if(/^#\s*"([^-]+)-\w+" information/) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment about what each test matches would be useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean put a comment before or after each if/elsif pattern match.
|
I would probably just shorten the description in the .txt file so that it just mentions Cipher (or remove it altogether). It only does one operation so it should be obvious.. |
This imports all of the NIST CAVS test vectors for CCM (SP800-38C) and coverts them for use within evp_test. This commit also adds a script to convert the .rsp CAVS files into the evp_test format.
b03fb81
to
a282020
Compare
I removed that comment from the commit message.
Done Also made all changes as suggested by @richsalz Please take another look. |
Pushed to master and 1.1.1. Thanks! |
This imports all of the NIST CAVS test vectors for CCM (SP800-38C) and coverts them for use within evp_test. This commit also adds a script to convert the .rsp CAVS files into the evp_test format. Reviewed-by: Shane Lontis <[email protected]> (Merged from #8981) (cherry picked from commit ecb0f14)
This imports all of the NIST CAVS test vectors for CCM (SP800-38C) and coverts them for use within evp_test. This commit also adds a script to convert the .rsp CAVS files into the evp_test format. Reviewed-by: Shane Lontis <[email protected]> (Merged from #8981)
This imports all of the NIST CAVS test vectors for CCM (SP800-38C) and
coverts them for use within evp_test. This commit also adds a script to
convert the .rsp CAVS files into the evp_test format. This script may work
for other CAVS test vectors but this is untested.