Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependabot: no longer set an "approval: otc review pending" label #25706

Closed
wants to merge 1 commit into from
Closed

Dependabot: no longer set an "approval: otc review pending" label #25706

wants to merge 1 commit into from

Conversation

kroeckx
Copy link
Member

@kroeckx kroeckx commented Oct 16, 2024

The label doesn't exist anymore.

@kroeckx kroeckx added branch: master Merge to master branch approval: review pending This pull request needs review by a committer labels Oct 16, 2024
@t8m t8m added triaged: bug The issue/pr is/fixes a bug tests: exempted The PR is exempt from requirements for testing labels Oct 16, 2024
@openssl-machine openssl-machine deleted the dependabot-review branch October 16, 2024 17:31
@t8m t8m restored the dependabot-review branch October 16, 2024 17:32
@t8m t8m reopened this Oct 16, 2024
@openssl-machine openssl-machine deleted the dependabot-review branch October 16, 2024 17:56
@kroeckx kroeckx restored the dependabot-review branch October 17, 2024 13:03
@kroeckx kroeckx reopened this Oct 17, 2024
@kroeckx
Copy link
Member Author

kroeckx commented Oct 17, 2024

Do we need to fight the machine because the branch was created in the openssl repo?

@t8m
Copy link
Member

t8m commented Oct 17, 2024

Do we need to fight the machine because the branch was created in the openssl repo?

Yes, unfortunately.

@t8m
Copy link
Member

t8m commented Oct 17, 2024

Ping @openssl/committers for the second review.

@tom-cosgrove-arm tom-cosgrove-arm added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Oct 17, 2024
@t8m
Copy link
Member

t8m commented Oct 18, 2024

@shahsb I am really curious what are your intentions with these approvals on PRs like this one. We very much appreciate external (non-committers) reviews which find issues with PRs. However the formal approvals by non-committers are not counted into the required approvals and thus do not provide that much value. Especially on trivial PRs like this one where there is not much to review at all. On bigger PRs it could be worth it to see that additional pair of eyes looked at the change and did not find any issues.

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@tom-cosgrove-arm tom-cosgrove-arm added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Oct 19, 2024
@openssl-machine openssl-machine deleted the dependabot-review branch October 21, 2024 10:34
@kroeckx kroeckx restored the dependabot-review branch October 21, 2024 11:54
@kroeckx kroeckx reopened this Oct 21, 2024
@openssl-machine openssl-machine deleted the dependabot-review branch October 21, 2024 14:06
@kroeckx kroeckx restored the dependabot-review branch October 22, 2024 06:59
@kroeckx kroeckx reopened this Oct 22, 2024
@t8m
Copy link
Member

t8m commented Oct 22, 2024

@mattcaswell can you please merge this as this is for master branch only?

@openssl-machine openssl-machine deleted the dependabot-review branch October 22, 2024 09:53
@kroeckx kroeckx restored the dependabot-review branch October 22, 2024 12:54
@kroeckx kroeckx reopened this Oct 22, 2024
@openssl-machine openssl-machine deleted the dependabot-review branch October 23, 2024 00:14
@kroeckx kroeckx restored the dependabot-review branch October 23, 2024 07:25
@kroeckx kroeckx reopened this Oct 23, 2024
@openssl-machine openssl-machine deleted the dependabot-review branch October 23, 2024 13:09
@t8m t8m restored the dependabot-review branch October 23, 2024 13:20
@t8m t8m reopened this Oct 23, 2024
@openssl-machine openssl-machine deleted the dependabot-review branch October 23, 2024 13:21
@t8m
Copy link
Member

t8m commented Oct 23, 2024

Merged to the master branch. Thank you

openssl-machine pushed a commit that referenced this pull request Oct 23, 2024
@kroeckx @t8m
Dependabot: no longer set an "approval: otc review pending" label
76783a8 
The label doesn't exist anymore.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tom Cosgrove <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from #25706)
coolshrid pushed a commit to coolshrid/openssl that referenced this pull request Nov 9, 2024
@kroeckx @coolshrid
Dependabot: no longer set an "approval: otc review pending" label
b76c522 
The label doesn't exist anymore.

Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tom Cosgrove <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from openssl#25706)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

@shahsb shahsb shahsb approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kroeckx @t8m @openssl-machine @paulidale @shahsb @tom-cosgrove-arm