Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow conversion of std::process::Command into a openssh::Command given a openssh::Session. #112

Merged
merged 27 commits into from
Jul 28, 2023
Merged

Allow conversion of std::process::Command into a openssh::Command given a openssh::Session. #112

merged 27 commits into from
Jul 28, 2023

Commits on Jul 28, 2023

  1. Add OverSsh trait to allow conversion of std::process::Command into a… 

    … openssh::Session.

Signed-off-by: Aalekh Patel <[email protected]>
    @aalekhpatel07 @NobodyXu
    aalekhpatel07 authored and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    e314422 View commit details
    Browse the repository at this point in the history

  2. Add a doc comment and example usage. 

    Signed-off-by: Aalekh Patel <[email protected]>
    @aalekhpatel07 @NobodyXu
    aalekhpatel07 authored and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    d9ba8d3 View commit details
    Browse the repository at this point in the history

  3. Add tests for OverSsh's with_session 

    Signed-off-by: Aalekh Patel <[email protected]>
    @aalekhpatel07 @NobodyXu
    aalekhpatel07 authored and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    dd64633 View commit details
    Browse the repository at this point in the history

  4. Use raw_command and raw_args. Refactor the name to 'over_ssh'. 

    Signed-off-by: Aalekh Patel <[email protected]>
    @aalekhpatel07 @NobodyXu
    aalekhpatel07 authored and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    9743a5e View commit details
    Browse the repository at this point in the history

  5. Remove a dangling test import. Use better name for test. 

    Signed-off-by: Aalekh Patel <[email protected]>
    @aalekhpatel07 @NobodyXu
    aalekhpatel07 authored and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    0a69ed1 View commit details
    Browse the repository at this point in the history

  6. Clean up doc comment. 

    Signed-off-by: Aalekh Patel <[email protected]>
    @aalekhpatel07 @NobodyXu
    aalekhpatel07 authored and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    974cd52 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions of code review. 

    Signed-off-by: Aalekh Patel <[email protected]>
    @aalekhpatel07 @NobodyXu
    aalekhpatel07 authored and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    cca22b1 View commit details
    Browse the repository at this point in the history

  8. Update src/command.rs 

    Co-authored-by: Jiahao XU <[email protected]>
    @aalekhpatel07 @NobodyXu
    aalekhpatel07 and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    66cecba View commit details
    Browse the repository at this point in the history

  9. Apply more suggestions from the code review. 

    Signed-off-by: Aalekh Patel <[email protected]>
    @aalekhpatel07 @NobodyXu
    aalekhpatel07 authored and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    511c62c View commit details
    Browse the repository at this point in the history

  10. Apply more suggestions from the code review. 

    Signed-off-by: Aalekh Patel <[email protected]>
    @aalekhpatel07 @NobodyXu
    aalekhpatel07 authored and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    d14a4c2 View commit details
    Browse the repository at this point in the history

  11. Update src/command.rs 

    Co-authored-by: Jiahao XU <[email protected]>
    @aalekhpatel07 @NobodyXu
    aalekhpatel07 and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    32a8960 View commit details
    Browse the repository at this point in the history

  12. Update src/lib.rs 

    Co-authored-by: Jiahao XU <[email protected]>
    @aalekhpatel07 @NobodyXu
    aalekhpatel07 and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    08b77a5 View commit details
    Browse the repository at this point in the history

  13. Update src/escape.rs 

    Co-authored-by: Jiahao XU <[email protected]>
    @aalekhpatel07 @NobodyXu
    aalekhpatel07 and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    5d9a112 View commit details
    Browse the repository at this point in the history

  14. Apply more suggestions. Add a test for non-utf8 chars for escape.

    @aalekhpatel07 @NobodyXu
    aalekhpatel07 authored and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    7d84871 View commit details
    Browse the repository at this point in the history

  15. Slight refactor of escape. 

    Signed-off-by: Aalekh Patel <[email protected]>
    @CdnCentreForChildProtection @NobodyXu
    CdnCentreForChildProtection authored and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    c4baafd View commit details
    Browse the repository at this point in the history

  16. Run cargo clippy --fix and persist all modifications to escape.rs 

    Signed-off-by: Aalekh Patel <[email protected]>
    @CdnCentreForChildProtection @NobodyXu
    CdnCentreForChildProtection authored and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    7e84beb View commit details
    Browse the repository at this point in the history

  17. Apply rustfmt to command.rs and escape.rs 

    Signed-off-by: Aalekh Patel <[email protected]>
    @CdnCentreForChildProtection @NobodyXu
    CdnCentreForChildProtection authored and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    7fcfaf2 View commit details
    Browse the repository at this point in the history

  18. Lint over_session test 

    Signed-off-by: Aalekh Patel <[email protected]>
    @CdnCentreForChildProtection @NobodyXu
    CdnCentreForChildProtection authored and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    13d865a View commit details
    Browse the repository at this point in the history

  19. Update src/escape.rs 

    Co-authored-by: Jiahao XU <[email protected]>
    @aalekhpatel07 @NobodyXu
    aalekhpatel07 and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    c4ded38 View commit details
    Browse the repository at this point in the history

  20. Update src/escape.rs 

    Co-authored-by: Jiahao XU <[email protected]>
    @aalekhpatel07 @NobodyXu
    aalekhpatel07 and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    67d0885 View commit details
    Browse the repository at this point in the history

  21. Update src/escape.rs 

    Co-authored-by: Jiahao XU <[email protected]>
    @aalekhpatel07 @NobodyXu
    aalekhpatel07 and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    6970753 View commit details
    Browse the repository at this point in the history

  22. Apply more suggestions. 

    Signed-off-by: Aalekh Patel <[email protected]>
    @aalekhpatel07 @NobodyXu
    aalekhpatel07 authored and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    8207907 View commit details
    Browse the repository at this point in the history

  23. Rustfmt fix. 

    Signed-off-by: Aalekh Patel <[email protected]>
    @aalekhpatel07 @NobodyXu
    aalekhpatel07 authored and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    10687fb View commit details
    Browse the repository at this point in the history

  24. Fix a doctest for overssh. 

    Signed-off-by: Aalekh Patel <[email protected]>
    @aalekhpatel07 @NobodyXu
    aalekhpatel07 authored and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    020366a View commit details
    Browse the repository at this point in the history

  25. Add a test for overssh that requires escaping the argument passed to … 

    …the command.

Signed-off-by: Aalekh Patel <[email protected]>
    @aalekhpatel07 @NobodyXu
    aalekhpatel07 authored and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    6842e5a View commit details
    Browse the repository at this point in the history

  26. Update overssh require-escaping-arguments test to contain a space. 

    Signed-off-by: Aalekh Patel <[email protected]>
    @aalekhpatel07 @NobodyXu
    aalekhpatel07 authored and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    e09d2fd View commit details
    Browse the repository at this point in the history

  27. Apply rustfmt to tests/openssh.rs 

    Signed-off-by: Aalekh Patel <[email protected]>
    @aalekhpatel07 @NobodyXu
    aalekhpatel07 authored and NobodyXu committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    f30d34e View commit details
    Browse the repository at this point in the history