Skip to content

Conversation

@calmwalija
Copy link

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes https://github.com/opensrp/fhir-resources/issues/890

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #2125 (c9144cc) into mwcore-dev (d97874b) will decrease coverage by 0.1%.
The diff coverage is 64.7%.

❗ Current head c9144cc differs from pull request most recent head 179dab8. Consider uploading reports for the commit 179dab8 to get more accurate results

Impacted file tree graph

@@              Coverage Diff               @@
##             mwcore-dev   #2125     +/-   ##
==============================================
- Coverage          64.6%   64.6%   -0.1%     
+ Complexity          829     828      -1     
==============================================
  Files               143     143             
  Lines              5213    5220      +7     
  Branches            862     866      +4     
==============================================
+ Hits               3371    3374      +3     
- Misses             1330    1331      +1     
- Partials            512     515      +3     
Flag Coverage Δ
engine 64.6% <64.7%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/engine/data/local/register/dao/HivRegisterDao.kt 80.7% <0.0%> (ø)
...hircore/engine/util/extension/AndroidExtensions.kt 31.2% <33.3%> (+0.2%) ⬆️
...er/fhircore/engine/util/extension/TaskExtension.kt 68.1% <85.7%> (+3.1%) ⬆️
...rtregister/fhircore/engine/ui/login/LoginScreen.kt 76.3% <100.0%> (-0.2%) ⬇️

@LZRS LZRS force-pushed the 890-questmalawi-core-in-the-app-sort-the-order-of-the-tasks-on-the-patient-profile-with-double-values-bug-fix branch from 4d3b151 to 245aa76 Compare March 9, 2023 10:49
@LZRS LZRS force-pushed the 890-questmalawi-core-in-the-app-sort-the-order-of-the-tasks-on-the-patient-profile-with-double-values-bug-fix branch 2 times, most recently from c9144cc to 179dab8 Compare March 9, 2023 13:17
@calmwalija calmwalija merged commit 758a5e4 into mwcore-dev Mar 10, 2023
@calmwalija calmwalija deleted the 890-questmalawi-core-in-the-app-sort-the-order-of-the-tasks-on-the-patient-profile-with-double-values-bug-fix branch March 10, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants