Skip to content

Conversation

@sevenreup
Copy link

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number]

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@sevenreup sevenreup self-assigned this Feb 28, 2023
@sevenreup sevenreup requested a review from calmwalija February 28, 2023 09:53
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #2097 (c678dc5) into mwcore-dev (d97874b) will decrease coverage by 0.05%.
The diff coverage is 58.33%.

@@               Coverage Diff                @@
##             mwcore-dev    #2097      +/-   ##
================================================
- Coverage         64.66%   64.61%   -0.05%     
+ Complexity          829      828       -1     
================================================
  Files               143      143              
  Lines              5213     5217       +4     
  Branches            862      866       +4     
================================================
  Hits               3371     3371              
- Misses             1330     1331       +1     
- Partials            512      515       +3     
Flag Coverage Δ
engine 64.61% <58.33%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/engine/data/local/register/dao/HivRegisterDao.kt 80.75% <0.00%> (ø)
...hircore/engine/util/extension/AndroidExtensions.kt 31.25% <33.33%> (+0.21%) ⬆️
...rtregister/fhircore/engine/ui/login/LoginScreen.kt 76.36% <100.00%> (-0.11%) ⬇️
...er/fhircore/engine/util/extension/TaskExtension.kt 63.15% <100.00%> (-1.85%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sevenreup sevenreup merged commit c5d906e into mwcore-dev Feb 28, 2023
@sevenreup sevenreup deleted the mw-appversion branch February 28, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants