Skip to content

Conversation

@LZRS
Copy link
Contributor

@LZRS LZRS commented Feb 10, 2023

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #2037

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@LZRS LZRS self-assigned this Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #2038 (d97874b) into mwcore-dev (7cca3a0) will increase coverage by 0.20%.
The diff coverage is 61.11%.

@@               Coverage Diff                @@
##             mwcore-dev    #2038      +/-   ##
================================================
+ Coverage         64.46%   64.66%   +0.20%     
- Complexity          816      829      +13     
================================================
  Files               139      143       +4     
  Lines              5110     5213     +103     
  Branches            837      862      +25     
================================================
+ Hits               3294     3371      +77     
- Misses             1329     1330       +1     
- Partials            487      512      +25     
Flag Coverage Δ
engine 64.66% <61.11%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...fhircore/engine/configuration/app/ConfigService.kt 70.00% <ø> (+4.78%) ⬆️
...e/data/local/register/PatientRegisterRepository.kt 0.00% <0.00%> (ø)
...ata/remote/fhir/resource/FhirXFhirQueryResolver.kt 0.00% <0.00%> (ø)
...ter/fhircore/engine/domain/model/SideMenuOption.kt 0.00% <0.00%> (ø)
...r/fhircore/engine/domain/repository/RegisterDao.kt 40.00% <0.00%> (-10.00%) ⬇️
...martregister/fhircore/engine/sync/AppSyncWorker.kt 0.00% <0.00%> (ø)
...ster/fhircore/engine/sync/SyncParametersManager.kt 0.00% <0.00%> (ø)
...r/fhircore/engine/ui/register/RegisterViewModel.kt 86.84% <ø> (-0.34%) ⬇️
...smartregister/fhircore/engine/sync/NetworkState.kt 26.66% <26.66%> (ø)
...hircore/engine/util/extension/ResourceExtension.kt 71.07% <50.00%> (-0.36%) ⬇️
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LZRS LZRS requested review from calmwalija and sevenreup February 13, 2023 07:12
@LZRS LZRS marked this pull request as ready for review February 13, 2023 07:12
@LZRS LZRS merged commit b32ed65 into mwcore-dev Feb 13, 2023
@LZRS LZRS deleted the fix-menu-count-anr branch February 13, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants