Skip to content

Conversation

@sevenreup
Copy link

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number]

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@sevenreup sevenreup requested a review from calmwalija January 18, 2023 06:23
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #1957 (a4697cc) into mwcore-dev (7cca3a0) will increase coverage by 0.31%.
The diff coverage is 61.96%.

@@               Coverage Diff                @@
##             mwcore-dev    #1957      +/-   ##
================================================
+ Coverage         64.46%   64.77%   +0.31%     
- Complexity          816      830      +14     
================================================
  Files               139      143       +4     
  Lines              5110     5215     +105     
  Branches            837      862      +25     
================================================
+ Hits               3294     3378      +84     
+ Misses             1329     1325       -4     
- Partials            487      512      +25     
Flag Coverage Δ
engine 64.77% <61.96%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...fhircore/engine/configuration/app/ConfigService.kt 70.00% <ø> (+4.78%) ⬆️
...e/data/local/register/PatientRegisterRepository.kt 0.00% <0.00%> (ø)
...ata/remote/fhir/resource/FhirXFhirQueryResolver.kt 0.00% <0.00%> (ø)
...r/fhircore/engine/domain/repository/RegisterDao.kt 40.00% <0.00%> (-10.00%) ⬇️
...martregister/fhircore/engine/sync/AppSyncWorker.kt 0.00% <0.00%> (ø)
...ster/fhircore/engine/sync/SyncParametersManager.kt 0.00% <0.00%> (ø)
...r/fhircore/engine/ui/register/RegisterViewModel.kt 86.84% <ø> (-0.34%) ⬇️
...smartregister/fhircore/engine/sync/NetworkState.kt 26.66% <26.66%> (ø)
...hircore/engine/util/extension/ResourceExtension.kt 71.07% <50.00%> (-0.36%) ⬇️
...hircore/engine/ui/register/BaseRegisterActivity.kt 66.98% <54.54%> (-0.32%) ⬇️
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sevenreup sevenreup merged commit 8e356bd into mwcore-dev Jan 18, 2023
@sevenreup sevenreup deleted the internal-realse-0.1.4 branch January 18, 2023 06:34
@sevenreup sevenreup restored the internal-realse-0.1.4 branch January 18, 2023 06:34
@sevenreup sevenreup deleted the internal-realse-0.1.4 branch January 18, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants