Skip to content

Conversation

@calmwalija
Copy link

@calmwalija calmwalija commented Dec 18, 2022

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes https://github.com/opensrp/fhir-resources/issues/470

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #1913 (fadadbc) into mwcore-dev (7cca3a0) will decrease coverage by 0.01%.
The diff coverage is 68.80%.

@@               Coverage Diff                @@
##             mwcore-dev    #1913      +/-   ##
================================================
- Coverage         64.46%   64.45%   -0.02%     
- Complexity          816      826      +10     
================================================
  Files               139      140       +1     
  Lines              5110     5204      +94     
  Branches            837      860      +23     
================================================
+ Hits               3294     3354      +60     
- Misses             1329     1348      +19     
- Partials            487      502      +15     
Flag Coverage Δ
engine 64.45% <68.80%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/data/local/register/PatientRegisterRepository.kt 0.00% <0.00%> (ø)
...r/fhircore/engine/domain/repository/RegisterDao.kt 40.00% <0.00%> (-10.00%) ⬇️
...hircore/engine/util/extension/ResourceExtension.kt 70.83% <0.00%> (-0.60%) ⬇️
...smartregister/fhircore/engine/sync/NetworkState.kt 26.66% <26.66%> (ø)
...egister/fhircore/engine/ui/login/LoginViewModel.kt 66.97% <66.66%> (-0.01%) ⬇️
...ster/fhircore/engine/task/FhirCarePlanGenerator.kt 64.63% <73.68%> (+2.13%) ⬆️
...rtregister/fhircore/engine/sync/SyncBroadcaster.kt 81.81% <73.91%> (-14.34%) ⬇️
...rtregister/fhircore/engine/ui/login/LoginScreen.kt 76.47% <76.19%> (+0.28%) ⬆️
...e/engine/data/local/register/dao/HivRegisterDao.kt 83.17% <88.00%> (+0.54%) ⬆️
...ister/fhircore/engine/auth/AccountAuthenticator.kt 73.33% <100.00%> (+0.55%) ⬆️
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@calmwalija calmwalija requested a review from LZRS December 19, 2022 08:02
@calmwalija calmwalija self-assigned this Dec 19, 2022
@calmwalija calmwalija merged commit c4f6fcd into mwcore-dev Dec 19, 2022
@calmwalija calmwalija deleted the 470-questmalawi-core-show-success-dialog-after-finish-visit-questionnaire-is-saved branch December 19, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants