Skip to content

Conversation

@sevenreup
Copy link

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number]

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@sevenreup sevenreup self-assigned this Nov 29, 2022
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #1868 (93de0a3) into mwcore-dev (7cca3a0) will decrease coverage by 0.00%.
The diff coverage is 69.16%.

@@               Coverage Diff                @@
##             mwcore-dev    #1868      +/-   ##
================================================
- Coverage         64.46%   64.45%   -0.01%     
- Complexity          816      827      +11     
================================================
  Files               139      140       +1     
  Lines              5110     5199      +89     
  Branches            837      859      +22     
================================================
+ Hits               3294     3351      +57     
- Misses             1329     1347      +18     
- Partials            487      501      +14     
Flag Coverage Δ
engine 64.45% <69.16%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/data/local/register/PatientRegisterRepository.kt 0.00% <0.00%> (ø)
...r/fhircore/engine/domain/repository/RegisterDao.kt 40.00% <0.00%> (-10.00%) ⬇️
...smartregister/fhircore/engine/sync/NetworkState.kt 26.66% <26.66%> (ø)
...egister/fhircore/engine/ui/login/LoginViewModel.kt 66.97% <66.66%> (-0.01%) ⬇️
...rtregister/fhircore/engine/sync/SyncBroadcaster.kt 81.81% <73.91%> (-14.34%) ⬇️
...ster/fhircore/engine/task/FhirCarePlanGenerator.kt 64.55% <75.00%> (+2.05%) ⬆️
...rtregister/fhircore/engine/ui/login/LoginScreen.kt 76.47% <76.19%> (+0.28%) ⬆️
...e/engine/data/local/register/dao/HivRegisterDao.kt 83.17% <88.00%> (+0.54%) ⬆️
...ister/fhircore/engine/auth/AccountAuthenticator.kt 73.33% <100.00%> (+0.55%) ⬆️
...gister/fhircore/engine/domain/model/ProfileData.kt 98.50% <100.00%> (+0.02%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sevenreup sevenreup requested a review from LZRS November 29, 2022 11:45
Copy link
Contributor

@LZRS LZRS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sevenreup sevenreup merged commit 7ed2cb3 into opensrp:mwcore-dev Dec 6, 2022
@sevenreup sevenreup deleted the mw-careplane-finish branch December 6, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants