Pass signed in Practitioner resource to every questionnaire #1858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## mwcore-dev #1858 +/- ##
================================================
- Coverage 64.46% 64.42% -0.04%
- Complexity 816 825 +9
================================================
Files 139 140 +1
Lines 5110 5184 +74
Branches 837 853 +16
================================================
+ Hits 3294 3340 +46
- Misses 1329 1347 +18
- Partials 487 497 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
LZRS
requested changes
Nov 24, 2022
| val resources = conditions + guardiansRelatedPersonResource + observations | ||
| val resourcesAsBundle = Bundle().apply { resources.map { this.addEntry().resource = it } } | ||
| arrayListOf(*carePlans.toTypedArray(), resourcesAsBundle) | ||
| arrayListOf(*practitioners.toTypedArray(), resourcesAsBundle) |
There was a problem hiding this comment.
Returned list seems to not include careplans from previous line. Maybe merge to return all in a single list
LZRS
approved these changes
Nov 24, 2022
calmwalija
deleted the
432-questmalawi-core-pass-signed-in-practitioner-resource-to-every-questionnaire
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes https://github.com/opensrp/fhir-resources/issues/432
Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guide