Skip to content

Conversation

@calmwalija
Copy link

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #https://github.com/opensrp/fhir-resources/issues/369

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@calmwalija calmwalija self-assigned this Nov 11, 2022
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #1829 (e20331b) into mwcore-dev (7cca3a0) will decrease coverage by 0.05%.
The diff coverage is 66.66%.

@@               Coverage Diff                @@
##             mwcore-dev    #1829      +/-   ##
================================================
- Coverage         64.46%   64.40%   -0.06%     
- Complexity          816      823       +7     
================================================
  Files               139      140       +1     
  Lines              5110     5175      +65     
  Branches            837      852      +15     
================================================
+ Hits               3294     3333      +39     
- Misses             1329     1346      +17     
- Partials            487      496       +9     
Flag Coverage Δ
engine 64.40% <66.66%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/data/local/register/PatientRegisterRepository.kt 0.00% <0.00%> (ø)
...r/fhircore/engine/domain/repository/RegisterDao.kt 40.00% <0.00%> (-10.00%) ⬇️
...smartregister/fhircore/engine/sync/NetworkState.kt 26.66% <26.66%> (ø)
...egister/fhircore/engine/ui/login/LoginViewModel.kt 66.97% <66.66%> (-0.01%) ⬇️
...rtregister/fhircore/engine/sync/SyncBroadcaster.kt 81.81% <73.91%> (-14.34%) ⬇️
...rtregister/fhircore/engine/ui/login/LoginScreen.kt 76.47% <76.19%> (+0.28%) ⬆️
...e/engine/data/local/register/dao/HivRegisterDao.kt 83.49% <93.75%> (+0.86%) ⬆️
...ister/fhircore/engine/auth/AccountAuthenticator.kt 73.33% <100.00%> (+0.55%) ⬆️
...register/fhircore/engine/ui/login/LoginActivity.kt 72.13% <100.00%> (+3.04%) ⬆️
...e/engine/ui/questionnaire/QuestionnaireActivity.kt 73.36% <100.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@calmwalija calmwalija requested a review from LZRS November 15, 2022 14:46
@calmwalija calmwalija merged commit ee269d0 into mwcore-dev Nov 16, 2022
@calmwalija calmwalija deleted the 369-questmalawi-core-update-no-internet-connectivity-message branch November 16, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants