Skip to content

Conversation

@LZRS
Copy link
Contributor

@LZRS LZRS commented Jul 29, 2022

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #1478

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@LZRS LZRS requested a review from AbdulWahabMemon July 29, 2022 14:05
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #1479 (8c850f1) into mwcore-dev (66d403e) will increase coverage by 0.04%.
The diff coverage is 80.00%.

@@               Coverage Diff                @@
##             mwcore-dev    #1479      +/-   ##
================================================
+ Coverage         63.48%   63.52%   +0.04%     
- Complexity          753      754       +1     
================================================
  Files               136      136              
  Lines              4814     4823       +9     
  Branches            765      769       +4     
================================================
+ Hits               3056     3064       +8     
  Misses             1312     1312              
- Partials            446      447       +1     
Flag Coverage Δ
engine 63.52% <80.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/engine/data/local/register/dao/HivRegisterDao.kt 81.57% <33.33%> (-0.86%) ⬇️
...ister/fhircore/engine/domain/model/RegisterData.kt 72.85% <100.00%> (+0.39%) ⬆️
...fhircore/engine/util/extension/PatientExtension.kt 72.22% <100.00%> (+1.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@LZRS LZRS marked this pull request as ready for review August 1, 2022 09:08
AbdulWahabMemon
AbdulWahabMemon previously approved these changes Aug 1, 2022
@LZRS LZRS merged commit 6c2d509 into mwcore-dev Aug 3, 2022
@LZRS LZRS deleted the 1478-breastfeeding-female-clients branch August 3, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants