Skip to content

Conversation

@LZRS
Copy link
Contributor

@LZRS LZRS commented Jul 27, 2022

Fixes #1470

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@LZRS LZRS requested a review from AbdulWahabMemon July 27, 2022 17:49
@LZRS LZRS self-assigned this Jul 27, 2022
@LZRS LZRS force-pushed the 1470-implement-guardian-visit branch from 5da2c66 to 465eed0 Compare July 27, 2022 17:51
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #1473 (94e867a) into mwcore-dev (0ae3f3c) will increase coverage by 0.13%.
The diff coverage is 76.47%.

@@               Coverage Diff                @@
##             mwcore-dev    #1473      +/-   ##
================================================
+ Coverage         63.56%   63.70%   +0.13%     
- Complexity          754      759       +5     
================================================
  Files               136      136              
  Lines              4836     4849      +13     
  Branches            771      775       +4     
================================================
+ Hits               3074     3089      +15     
+ Misses             1313     1311       -2     
  Partials            449      449              
Flag Coverage Δ
engine 63.70% <76.47%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...er/fhircore/engine/util/extension/TaskExtension.kt 44.44% <0.00%> (-5.56%) ⬇️
...e/engine/data/local/register/dao/HivRegisterDao.kt 80.00% <83.33%> (ø)
...r/fhircore/engine/domain/model/OverflowMenuItem.kt 100.00% <100.00%> (+100.00%) ⬆️
...gister/fhircore/engine/domain/model/ProfileData.kt 98.36% <100.00%> (+0.02%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

to allow control of menu items to show dynamically
@LZRS LZRS force-pushed the 1470-implement-guardian-visit branch from 940a1e6 to d1b43de Compare July 28, 2022 09:24
@LZRS LZRS marked this pull request as ready for review August 1, 2022 10:04
@LZRS LZRS force-pushed the 1470-implement-guardian-visit branch 5 times, most recently from 70386ef to a7bc737 Compare August 5, 2022 02:53
@LZRS LZRS force-pushed the 1470-implement-guardian-visit branch from a7bc737 to e980440 Compare August 5, 2022 12:00
@LZRS LZRS merged commit d0baf85 into mwcore-dev Aug 5, 2022
@LZRS LZRS deleted the 1470-implement-guardian-visit branch August 5, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants