Implement Multiple practitioners details endpoint #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndegwamartin
force-pushed
the
multiple-practitioner-details
branch
from
7146c4b to
daded4c
Compare
- Return Practitoner object in Practitioner Details
- Return Practitioners as Array List - Return OrganizationAffiliations - Migrate fhir-common-utils library
ndegwamartin
force-pushed
the
multiple-practitioner-details
branch
from
bce891a to
ddd8d9e
Compare
pld
requested changes
Jul 31, 2023
| import org.smartregister.utils.Constants; | ||
| import org.springframework.lang.Nullable; | ||
|
|
||
| public class OpenSRPHelper { |
Member
There was a problem hiding this comment.
can we rename this class with something more semantic? Like RelationshipManagementHelper
Author
There was a problem hiding this comment.
The idea was that it would be generic to contain other helper methods for extended functionality. Right now it only supports the multi-practitioner details endpoint so maybe for now we can re-name it to something that alludes to that.
Author
There was a problem hiding this comment.
Renamed it from OpenSRPHelper to PractitionerDetailsEndpointHelper
plugins/src/main/java/com/google/fhir/gateway/plugin/OpenSRPHelper.java
Outdated
Show resolved
Hide resolved
plugins/src/main/java/com/google/fhir/gateway/plugin/OpenSRPHelper.java
Outdated
Show resolved
Hide resolved
ndegwamartin
force-pushed
the
multiple-practitioner-details
branch
from
ee5b31a to
cb0f739
Compare
Member
|
Yeah renaming to focus on that makes sense, I'd prefer multiple plug-ins specific to the issues they deal with
… On Aug 1, 2023, at 02:58, Martin Ndegwa ***@***.***> wrote:
@ndegwamartin commented on this pull request.
In plugins/src/main/java/com/google/fhir/gateway/plugin/OpenSRPHelper.java:
> +import org.hl7.fhir.r4.model.Location;
+import org.hl7.fhir.r4.model.Organization;
+import org.hl7.fhir.r4.model.OrganizationAffiliation;
+import org.hl7.fhir.r4.model.Practitioner;
+import org.hl7.fhir.r4.model.PractitionerRole;
+import org.jetbrains.annotations.NotNull;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.smartregister.model.location.LocationHierarchy;
+import org.smartregister.model.location.ParentChildrenMap;
+import org.smartregister.model.practitioner.FhirPractitionerDetails;
+import org.smartregister.model.practitioner.PractitionerDetails;
+import org.smartregister.utils.Constants;
+import org.springframework.lang.Nullable;
+
+public class OpenSRPHelper {
The idea was that it would be generic to contain other helper methods for extended functionality. Right now it only supports the multi-practitioner details endpoint so maybe for now we can re-name it to something that alludes to that.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.
|
pld
reviewed
Aug 2, 2023
Member
There was a problem hiding this comment.
cool, so I know this is an existing class, but think it should be renamed to simply
SyncAccessDecision
I don't see this as OpenSRP specific
Author
There was a problem hiding this comment.
Cool, I can rename this on the PR cc @rehammuzzamil and @dubdabasoduba
Signed-off-by: Martin Ndegwa <[email protected]>
pld
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes opensrp/fhircore#2609