Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix communication error handling #64

Merged
merged 6 commits into from
Dec 3, 2019
Merged

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Nov 20, 2019

This change fixes error handling to avoid sending SIGINT after the error in ypspur-coordinator.

@at-wat at-wat self-assigned this Nov 20, 2019
if (t == 0.0)
t = now.toSec();
if (t <= 0.0)
break;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exit on inter process communication error.

}
};

int main(int argc, char* argv[])
{
ros::init(argc, argv, "ypspur_ros");
ros::NodeHandle nh;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for ROS_ERROR

@at-wat at-wat requested a review from seiga-k November 29, 2019 04:29
@at-wat
Copy link
Member Author

at-wat commented Nov 29, 2019

@seiga-k please take a look.
related to openspur/yp-spur#120

Copy link
Contributor

@seiga-k seiga-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@at-wat at-wat merged commit bed56dd into master Dec 3, 2019
@at-wat at-wat deleted the fix-communication-error-handling branch December 3, 2019 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants