Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encoder denominator parameter #86

Merged
merged 6 commits into from
Jan 31, 2019
Merged

Add encoder denominator parameter #86

merged 6 commits into from
Jan 31, 2019

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Jan 29, 2019

No description provided.

@at-wat at-wat self-assigned this Jan 29, 2019
Copy link
Member Author

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add protocol version check

src/param.c Outdated Show resolved Hide resolved
if (g_param.device_version <= 9)
{
yprintf(OUTPUT_LV_ERROR, "ERROR: the device doesn't support ENCODER_DENOMINATOR\n");
return 0;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this to a separate PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be in this PR

src/param.c Outdated Show resolved Hide resolved
src/param.c Outdated Show resolved Hide resolved
@@ -27,7 +27,7 @@ set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${CMAKE_CURRENT_SOURCE_DIR}/cmake/mod

set(YP_VENDOR_NAME "OpenSpur.org")
set(YP_PRODUCT_NAME "Yamabico Project - Spur")
set(YP_PROTOCOL_NAME "YPP:09:03")
set(YP_PROTOCOL_NAME "YPP:10:04")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supporting v6 to v10

@at-wat at-wat merged commit 1f5c325 into master Jan 31, 2019
@at-wat at-wat deleted the add-enc-denominator branch January 31, 2019 04:46
@at-wat at-wat mentioned this pull request Feb 4, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant