Add zoom to coords #127
Merged
Add zoom to coords #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasttvo
reviewed
Dec 3, 2024
| ) | ||
| return false; | ||
| // Just exposing _zoomToLocation | ||
| this._zoomToLocation(x, y, newZoomLevel); |
There was a problem hiding this comment.
probably need a return true here
thomasttvo
reviewed
Dec 3, 2024
src/ReactNativeZoomableView.tsx
Outdated
| * Sets zoom relative to a "zoom subject" which is the relative coordinates | ||
| * of the view | ||
| */ | ||
| zoomToZoomSubject(x: number, y: number, newZoomLevel: number) { |
There was a problem hiding this comment.
maybe just build this into zoomTo.
To prevent API change you can do zoomTo(newZoomLevel: number, x?: number, y?: number)
thomasttvo
approved these changes
Dec 3, 2024
thomasttvo
reviewed
Dec 3, 2024
src/ReactNativeZoomableView.tsx
Outdated
| * Sets zoom relative to a "zoom subject" which is the relative coordinates | ||
| * of the view | ||
| */ | ||
| zoomToZoomSubject(x: number, y: number, newZoomLevel: number) { |
There was a problem hiding this comment.
also, fyi zoomSubject is a term used in this library to refer to the whole transformed view all the way below, rather than a particular coordinate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need a zoom to coords for OS