Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null check staticPinPosition #118

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Null check staticPinPosition #118

merged 1 commit into from
Oct 21, 2024

Conversation

dmurphy5
Copy link

@dmurphy5 dmurphy5 commented Oct 21, 2024 •
edited
Loading

What we really need is #114 but this fixes a bug where a runtime error is thrown if onInvokeTransform is called without a staticPinPosition

@dmurphy5 dmurphy5 changed the base branch from master to v3 October 21, 2024 18:49
@dmurphy5 dmurphy5 changed the base branch from v3 to master October 21, 2024 18:50
@dmurphy5 dmurphy5 marked this pull request as ready for review October 21, 2024 19:28
@dmurphy5 dmurphy5 merged commit 9a34aa2 into master Oct 21, 2024
1 check passed
@dmurphy5 dmurphy5 deleted the dylan/staticPinPosition branch October 21, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliottkember elliottkember elliottkember approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmurphy5 @elliottkember