Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrupted published package - export 'ReactNativeZoomableViewProps' was not found in './typings' #22

Closed
lavor opened this issue Jan 21, 2022 · 5 comments · Fixed by #65
Labels
bug Something isn't working

Comments

@lavor
Copy link

lavor commented Jan 21, 2022

We are using this package in Expo with react-native-web. There is no issue in native application, but web displays following warnings right after build and also in a browser console:

./node_modules/@openspacelabs/react-native-zoomable-view/lib/module/index.js:4
"export 'ReactNativeZoomableViewProps' was not found in './typings'
  2 | import ReactNativeZoomableViewWithGestures from './ReactNativeZoomableViewWithGestures';
  3 | import { ReactNativeZoomableViewProps, ZoomableViewEvent } from './typings';
> 4 | export { ReactNativeZoomableView, ReactNativeZoomableViewWithGestures, ReactNativeZoomableViewProps, ZoomableViewEvent };
  5 | //# sourceMappingURL=index.js.map
  6 |
./node_modules/@openspacelabs/react-native-zoomable-view/lib/module/index.js:4
"export 'ZoomableViewEvent' was not found in './typings'
  2 | import ReactNativeZoomableViewWithGestures from './ReactNativeZoomableViewWithGestures';
  3 | import { ReactNativeZoomableViewProps, ZoomableViewEvent } from './typings';
> 4 | export { ReactNativeZoomableView, ReactNativeZoomableViewWithGestures, ReactNativeZoomableViewProps, ZoomableViewEvent };

I think that problem is somewhere in a build process, where exports of interfaces were not removed from built .js files properly.
When I try to comment out the problematic exports in ./node_modules/@openspacelabs/react-native-zoomable-view/lib/module/index.js, the warnings will disappear.

// File ./node_modules/@openspacelabs/react-native-zoomable-view/lib/module/index.js

import ReactNativeZoomableView from './ReactNativeZoomableView';
import ReactNativeZoomableViewWithGestures from './ReactNativeZoomableViewWithGestures';
// import { ReactNativeZoomableViewProps, ZoomableViewEvent } from './typings';
export { ReactNativeZoomableView, ReactNativeZoomableViewWithGestures /*, ReactNativeZoomableViewProps, ZoomableViewEvent*/ };
//# sourceMappingURL=index.js.map
@thomasttvo thomasttvo added the bug Something isn't working label May 17, 2022
@linojon
Copy link

linojon commented Aug 25, 2022

same here, version "^2.0.4"

@antonkristiono
Copy link

still no solution

@mgroeneweg
Copy link

Same issue, fix mentioned here works! Created a patch in my project to move forward. Hope this gets fixed soon.

mgroeneweg added a commit to Itvisors/mendix-NativeImageViewer that referenced this issue Nov 20, 2022
The patch prevents a build issue on exports that don't exists in the published package.
openspacelabs/react-native-zoomable-view#22
@ibovegar
Copy link

When will this be fixed?

@elliottkember
Copy link
Collaborator

@ibovegar @mgroeneweg @antonkristiono @linojon

Sorry for the delay. I've created #65 which I think will fix this by fixing the import syntax. Could you please try it and let me know?

Side note – PRs are always welcome and the best way to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants