topotato: use __slots__ on TimedElement

A lot of `TimedElement` are created and passed around during a normal topotato run. Use `__slots__` to make them a bit more efficient. Signed-off-by: David Lamparter <[email protected]>
opensourcerouting · Sep 17, 2024 · ec4cd41 · ec4cd41
1 parent f0ee9c9
commit ec4cd41
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 0 deletions.
diff --git a/topotato/frr/core.py b/topotato/frr/core.py
@@ -348,6 +348,16 @@ class TimedVtysh(TimedElement):
     This is used to know when to stop running the Timeline event poller.
     """
 
+    __slots__ = [
+        "_ts",
+        "rtrname",
+        "daemon",
+        "cmd",
+        "retcode",
+        "text",
+        "last",
+    ]
+
     # pylint: disable=too-many-arguments
     def __init__(
         self,

diff --git a/topotato/frr/livelog.py b/topotato/frr/livelog.py
@@ -111,6 +111,19 @@ class LogMessage(TimedElement):
     router: "FRRRouterNS"
     daemon: str
 
+    __slots__ = [
+        "header_fields",
+        "arghdrlen",
+        "args",
+        "rawtext",
+        "text",
+        "uid",
+        "_ts",
+        "_prio",
+        "router",
+        "daemon",
+    ]
+
     # mypy doesn't work with dynamic namedtuple
     @typing.no_type_check
     def __init__(self, router: "FRRRouterNS", daemon: str, rawmsg: bytes):

diff --git a/topotato/livescapy.py b/topotato/livescapy.py
@@ -20,6 +20,10 @@
 
 
 class TimedScapy(TimedElement):
+    __slots__ = [
+        "_pkt",
+    ]
+
     def __init__(self, pkt):
         super().__init__()
         self._pkt = pkt

diff --git a/topotato/timeline.py b/topotato/timeline.py
@@ -221,6 +221,10 @@ class TimedElement(ABC):
     If this object satisfied some test condition, the test item is recorded here.
     """
 
+    __slots__ = [
+        "match_for",
+    ]
+
     def __init__(self):
         super().__init__()
         self.match_for = []