topotato: force BGP unidirectional connect

Some of these tests are really flaky depending on which direction the session is established in :( Signed-off-by: David Lamparter <[email protected]>
opensourcerouting · May 3, 2024 · 33fd7fe · 33fd7fe
1 parent ef62856
commit 33fd7fe
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/test_bgp_as_wide_bgp_identifier.py b/test_bgp_as_wide_bgp_identifier.py
@@ -57,22 +57,28 @@ class Configs(FRRConfigs):
      no bgp ebgp-requires-policy
      neighbor 192.168.255.1 remote-as 65002
      neighbor 192.168.255.1 timers 3 10
+     neighbor 192.168.255.1 timers connect 1
     !
     #%   elif router.name == 'r2'
     router bgp 65002
      bgp router-id 10.10.10.10
      no bgp ebgp-requires-policy
      neighbor 192.168.255.2 remote-as 65001
+     neighbor 192.168.255.2 passive
      neighbor 192.168.255.2 timers 3 10
+     neighbor 192.168.255.2 timers connect 1
      neighbor 192.168.255.3 remote-as 65002
+     neighbor 192.168.255.3 passive
      neighbor 192.168.255.3 timers 3 10
+     neighbor 192.168.255.3 timers connect 1
     !
     #%   elif router.name == 'r3'
     router bgp 65002
      bgp router-id 10.10.10.10
      no bgp ebgp-requires-policy
      neighbor 192.168.255.1 remote-as 65002
      neighbor 192.168.255.1 timers 3 10
+     neighbor 192.168.255.1 timers connect 1
     !
     #%   endif
     #% endblock

diff --git a/test_bgp_default_originate_route_map_match_set.py b/test_bgp_default_originate_route_map_match_set.py
@@ -57,6 +57,7 @@ class Configs(FRRConfigs):
     router bgp 65001
      no bgp ebgp-requires-policy
      neighbor {{ routers.r1.ifaces[0].ip4[0].ip }} remote-as 65000
+     neighbor {{ routers.r1.ifaces[0].ip4[0].ip }} passive
      neighbor {{ routers.r1.ifaces[0].ip4[0].ip }} timers 3 10
      address-family ipv4 unicast
       redistribute connected
@@ -65,6 +66,7 @@ class Configs(FRRConfigs):
     router bgp 65000
      no bgp ebgp-requires-policy
      neighbor {{ routers.r2.ifaces[0].ip4[0].ip }} remote-as 65001
+     neighbor {{ routers.r2.ifaces[0].ip4[0].ip }} timers connect 1
      neighbor {{ routers.r2.ifaces[0].ip4[0].ip }} timers 3 10
      address-family ipv4 unicast
       redistribute connected

diff --git a/test_bgp_minimum_holdtime.py b/test_bgp_minimum_holdtime.py
@@ -57,13 +57,15 @@ class Configs(FRRConfigs):
      no bgp ebgp-requires-policy
      neighbor 192.168.255.1 remote-as 65000
      neighbor 192.168.255.1 timers 3 10
+     neighbor 192.168.255.1 passive
     !
     #%   elif router.name == 'r1'
     router bgp 65000
      bgp minimum-holdtime 20
      neighbor 192.168.255.2 remote-as 65001
      neighbor 192.168.255.2 timers 3 10
-     neighbor 192.168.255.2 timers connect 10
+     neighbor 192.168.255.2 timers connect 1
+    ## this test will fail if r1 is passive!
     !
     #%   endif
     #% endblock