Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topotato migrate bgp community alias from topotests #62

Closed
wants to merge 35 commits into from
Closed

Topotato migrate bgp community alias from topotests #62

wants to merge 35 commits into from

Conversation

Chromico
Copy link

Test results

root@frrr:~/newfrr1/tests/topotato# ./run_userns.sh --frr-builddir=/root/buildfrr/ --log-cli-level=DEBUG -v -v -x test_bgp-community-alias.py
========================================================================= topotato initialization =========================================================================

-------------------------------------------------------------------------- live log sessionstart --------------------------------------------------------------------------
DEBUG    topotato:topolinux.py:87 executable unshare found: /usr/bin/unshare
DEBUG    topotato:topolinux.py:87 executable nsenter found: /usr/bin/nsenter
DEBUG    topotato:topolinux.py:87 executable tini found: /usr/bin/tini
DEBUG    topotato:topolinux.py:87 executable dumpcap found: /usr/bin/dumpcap
DEBUG    topotato:topolinux.py:87 executable ip found: /usr/sbin/ip
DEBUG    topotato:frr.py:124 FRR build directory: '/root/buildfrr'
DEBUG    topotato:frr.py:139 FRR source directory: '/root/buildfrr'
INFO     topotato:frr.py:171 FRR daemons: zebra, staticd, babeld, bfdd, bgpd, eigrpd, fabricd, isisd, ldpd, nhrpd, ospf6d, ospfd, pathd, pbrd, pim6d, pimd, ripd, ripngd, vrrpd
DEBUG    topotato:frr.py:183 zebra => zebra/zebra
DEBUG    topotato:frr.py:181 ignoring target 'watchfrr/watchfrr'
DEBUG    topotato:frr.py:181 ignoring target 'tools/ssd'
DEBUG    topotato:frr.py:183 bgpd => bgpd/bgpd
DEBUG    topotato:frr.py:183 ripd => ripd/ripd
DEBUG    topotato:frr.py:183 ripngd => ripngd/ripngd
DEBUG    topotato:frr.py:183 ospfd => ospfd/ospfd
DEBUG    topotato:frr.py:183 ospf6d => ospf6d/ospf6d
DEBUG    topotato:frr.py:183 isisd => isisd/isisd
DEBUG    topotato:frr.py:183 fabricd => isisd/fabricd
DEBUG    topotato:frr.py:183 nhrpd => nhrpd/nhrpd
DEBUG    topotato:frr.py:183 ldpd => ldpd/ldpd
DEBUG    topotato:frr.py:183 babeld => babeld/babeld
DEBUG    topotato:frr.py:183 eigrpd => eigrpd/eigrpd
DEBUG    topotato:frr.py:183 pimd => pimd/pimd
DEBUG    topotato:frr.py:183 pbrd => pbrd/pbrd
DEBUG    topotato:frr.py:183 staticd => staticd/staticd
DEBUG    topotato:frr.py:183 bfdd => bfdd/bfdd
DEBUG    topotato:frr.py:183 vrrpd => vrrpd/vrrpd
DEBUG    topotato:frr.py:183 pathd => pathd/pathd
DEBUG    topotato:frr.py:181 ignoring target 'lib/grammar_sandbox'
DEBUG    topotato:frr.py:181 ignoring target 'lib/clippy'
DEBUG    topotato:frr.py:181 ignoring target 'tools/permutations'
DEBUG    topotato:frr.py:181 ignoring target 'tools/gen_northbound_callbacks'
DEBUG    topotato:frr.py:181 ignoring target 'tools/gen_yang_deviations'
DEBUG    topotato:frr.py:181 ignoring target 'bgpd/bgp_btoa'
DEBUG    topotato:frr.py:181 ignoring target 'bgpd/rfp-example/rfptest/rfptest'
DEBUG    topotato:frr.py:181 ignoring target 'ospfclient/ospfclient'
DEBUG    topotato:frr.py:181 ignoring target 'pimd/test_igmpv3_join'
DEBUG    topotato:frr.py:181 ignoring target 'pceplib/pcep_pcc'
DEBUG    topotato:pretty.py:396 executable dot found: /usr/bin/dot
Warning: daemon 'pim6d' not enabled in configure, skipping
=========================================================================== test session starts ===========================================================================
platform linux -- Python 3.8.10, pytest-6.2.4, py-1.11.0, pluggy-0.13.0 -- /usr/bin/python3
cachedir: .pytest_cache
rootdir: /root/newfrr1/tests/topotato, configfile: pytest.ini
collecting ... --------------------------------------------------------------------------- live log collection ---------------------------------------------------------------------------
DEBUG    topotato:pytestintegration.py:29 _topotato_makeitem(<Module test_bgp-community-alias.py>, 'TestBase', <class 'topotato.base.TestBase'>)
DEBUG    topotato:pytestintegration.py:29 _topotato_makeitem(<Module test_bgp-community-alias.py>, 'BGPCommunityAlias', <class 'test_bgp-community-alias.BGPCommunityAlias'>)
DEBUG    topotato:pytestintegration.py:29 _topotato_makeitem(<TopotatoInstance ()>, 'bgp_converge', <topotato.base.TopotatoWrapped object at 0x7fdf3e799dc0>)
DEBUG    topotato:pytestintegration.py:29 _topotato_makeitem(<TopotatoInstance ()>, 'bgp_show_prefixes_by_alias', <topotato.base.TopotatoWrapped object at 0x7fdf3e799f70>)
DEBUG    topotato:pytestintegration.py:29 _topotato_makeitem(<TopotatoInstance ()>, 'bgp_show_prefixes_by_large_community_list', <topotato.base.TopotatoWrapped object at 0x7fdf3e7994c0>)
DEBUG    topotato:base.py:552 collect on: <TopotatoFunction bgp_converge> test: <AssertVtysh #142:r1/zebra/vtysh "show ip route json">
DEBUG    topotato:base.py:552 collect on: <TopotatoFunction bgp_show_prefixes_by_alias> test: <AssertVtysh #162:r1/bgpd/vtysh "show bgp ipv4 unicast alias large-community-r2-1 json detail">
DEBUG    topotato:base.py:552 collect on: <TopotatoFunction bgp_show_prefixes_by_large_community_list> test: <AssertVtysh #173:r1/bgpd/vtysh "show bgp ipv4 unicast large-community-list r2 json">
collected 5 items                                                                                                                                                         

test_bgp-community-alias.py::BGPCommunityAlias::startup PASSED (0.95)                                                                                               [ 20%]
test_bgp-community-alias.py::BGPCommunityAlias::bgp_converge::#142:r1/zebra/vtysh "show ip route json" PASSED (4.81)                                                [ 40%]
test_bgp-community-alias.py::BGPCommunityAlias::bgp_show_prefixes_by_alias::#162:r1/bgpd/vtysh "show bgp ipv4 unicast alias large-community-r2-1 json detail" PASSED (0.01) [ 60%]
test_bgp-community-alias.py::BGPCommunityAlias::bgp_show_prefixes_by_large_community_list::#173:r1/bgpd/vtysh "show bgp ipv4 unicast large-community-list r2 json" PASSED (0.02) [ 80%]
test_bgp-community-alias.py::BGPCommunityAlias::shutdown PASSED (0.51)                                                                                              [100%]

============================================================================ 5 passed in 7.41s ============================================================================
root@frrr:~/newfrr1/tests/topotato#

patrasar and others added 30 commits March 28, 2022 05:44
@patrasar
pimd: rpf update when pim disabled/enabled
bc36ccd 
Topology :-

----ens192--------+---------+
R11 -------------R2--------R3
---ens256-------+---------+

R11: receiver
R2: RP
R3: source .
There are 2 links connected between each routers .

R11: Initially (,G) joins are sent over ens192 interface
R11(config)# do show ip pim upstream 225.0.7.208
Iif Source Group State Uptime JoinTimer RSTimer KATimer RefCnt
ens192 * 225.0.7.208 J 00:00:4 00:00:30 --:--:-- --:--:-- 1

Remove PIM from interface ens192 still (*,G) iif not changed

R11(config)# interface ens192
R11(config-if)# no ip pim
R11(config-if)# exit
R11(config)# do show ip pim upstream 225.0.7.208
Iif Source Group State Uptime JoinTimer RSTimer KATimer RefCnt
ens192 * 225.0.7.208 J 00:00:12 00:00:51 --:--:-- --:--:-- 1

Fix: pim upstream rpf update taken care when pim is enabled
or disabled on an interface.

Signed-off-by: sarita patra <[email protected]>
@patrasar
pim6d: modify in_addr current_bsr to pim_addr current_bsr
931a765 
Signed-off-by: sarita patra <[email protected]>
@patrasar
pim6d: bsr nht handling for IPV6
9bf456c 
Signed-off-by: sarita patra <[email protected]>
@patrasar
pim6d: Add pim_addr rp_addr in bsm_rpinfo
378a292 
Signed-off-by: sarita patra <[email protected]>
@patrasar
pim6d: add pimv6 support for bsm_hdr
a5d7f34 
Signed-off-by: sarita patra <[email protected]>
@patrasar
pim6d: add pimv6 support for bsmmsg_rpinfo
0fd22e1 
Signed-off-by: sarita patra <[email protected]>
@patrasar
pim6d: add pimv6 support for bsmmsg_grpinfo
c79d203 
Signed-off-by: sarita patra <[email protected]>
@patrasar
pim6d: running pim_bsm.c for pimv6
89fdce9 
Signed-off-by: sarita patra <[email protected]>
@patrasar
pim6d: remove unused variable neigh_src_str
b46c5e3 
Signed-off-by: sarita patra <[email protected]>
@patrasar
Revert "pim6d: IPv6-adjust BSM code"
bd79cc0 
This reverts commit 809c11a.
@patrasar
pim6d: IPV6 adjust in hash_calc_on_grp_rp
69b996c 
Signed-off-by: sarita patra <[email protected]>
@eqvinox
pim6d: add fresh MLD implementation
89fe7ba 
Fresh ground-up MLD implementation with subscriber-tracking for MLDv2.
Intended to be adapted for IPv4 and replace the IGMP implementation at a
later point.

Tested in ANVL, currently at 94/116.  Some issues/TODOs are left in the
code as CPP_NOTICE markers, but the code is very much good enough to
proceed since otherwise we're blocked on overall PIM v6 progress.

Signed-off-by: David Lamparter <[email protected]>
@eqvinox
pim6d: count stats for MLD
554a18f 
Signed-off-by: David Lamparter <[email protected]>
@eqvinox
pim6d: show MLD in running-config
30759ce 
Signed-off-by: David Lamparter <[email protected]>
@eqvinox
pim6d: add some show commands for MLD
15250c6 
Just some basic show commands to get going.

Signed-off-by: David Lamparter <[email protected]>
@eqvinox
pim6d: change MLD socket to be per VRF
c770aec 
Signed-off-by: David Lamparter <[email protected]>
@eqvinox
pim6d: don't start MLD when setting config
fc2092f 
Any interface parameters must be configurable without enabling the
protocol as a side effect; otherwise it becomes impossible to set up
things correctly without a transient misconfigured state.  Which may in
some cases break the network...

Signed-off-by: David Lamparter <[email protected]>
@eqvinox
pim6d: add MLD query-max-resp & robustness config
2b8865d 
Pending some YANG remodeling to get rid of weird time units...

Signed-off-by: David Lamparter <[email protected]>
@eqvinox
TEST ONLY: pim6d: load split-config for testing
2997976
@eqvinox
Merge remote-tracking branch 'frr/pull/11113' into pim6-ssm
f3541fb
@eqvinox
Merge branch 'pim6-mld' into pim6-ssm
5861459
@eqvinox
pim6d, tools: install pim6d
f1ad973 
... and add it to the daemon lists in the various tools.

Signed-off-by: David Lamparter <[email protected]>
@eqvinox
Merge remote-tracking branch 'frr/pull/10592' into pim6-ssm
f2cbe93
@eqvinox
pimd: fix format strings in FRRouting#10592
9e21727 
Signed-off-by: David Lamparter <[email protected]>
@eqvinox
Merge remote-tracking branch 'frr/pull/10742' into pim6-ssm
0f483ef
@eqvinox
TEST ONLY: pimd: disable unicast BSR messages by default
c188062 
... this is not configurable yet and ANVL needs it disabled.

Signed-off-by: David Lamparter <[email protected]>
@eqvinox
Merge remote-tracking branch 'frr/pull/10706' into pim6-testing
8768be1
@eqvinox
pimd: fix conflicts with FRRouting#10706
2419d00 
Signed-off-by: David Lamparter <[email protected]>
@eqvinox
pim6d: fix some odd warnings
2358bd7 
... not seeing these locally, but CI is complaining.

Signed-off-by: David Lamparter <[email protected]>
@eqvinox
Merge branch 'pim6-testing' into topotato
cbc26f2 
Signed-off-by: David Lamparter <[email protected]>
@eqvinox eqvinox mentioned this pull request Sep 14, 2022
Closed
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@eqvinox
Copy link

eqvinox commented Jun 6, 2023

outdated, closing

@eqvinox eqvinox closed this Jun 6, 2023
@Chromico Chromico mentioned this pull request Sep 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chromico @eqvinox @patrasar