[SERIALIZATION] add serialization and deserialization functionality for ClusterBean #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
May 23, 2023
garyparrot
reviewed
May 24, 2023
common/src/main/proto/org/astraea/common/generated/ClusterBean.proto
Outdated
Show resolved
Hide resolved
…ry variables in test.
# Conflicts: # common/src/test/java/org/astraea/common/ByteUtilsTest.java
… to readBeanObjects
|
LGTM 但衝突可能需要處理一下，感謝 @Haser0305 |
# Conflicts: # common/src/main/java/org/astraea/common/ByteUtils.java # common/src/test/java/org/astraea/common/ByteUtilsTest.java
garyparrot
previously approved these changes
May 28, 2023
|
麻煩確認一下失敗的測試 |
unrelated test failed track by #1784 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1710
新增可以將
ClusterBean序列化，並且轉回Map<Integer, List<BeanObject>>形式的方法