Safer one-way kill in close IPC socket test#251
Safer one-way kill in close IPC socket test#251Peque merged 2 commits intoopensistemas-hub:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #251 +/- ##
==========================================
+ Coverage 99.08% 99.08% +<.01%
==========================================
Files 26 26
Lines 3481 3503 +22
Branches 250 251 +1
==========================================
+ Hits 3449 3471 +22
Misses 20 20
Partials 12 12
Continue to review full report at Codecov.
|
ocaballeror
left a comment
There was a problem hiding this comment.
Looks good.
We should also probably change some of the other tests to use this function instead of arbitrary time.sleep() delays.
|
@ocaballeror Yeah, I bet there are a couple of tests that could benefit from this. I'll implement the "negated wait_condition()" too in that case and ask you for review again. We can then open a ticket to have a look at where we could use this function. |
|
@ocaballeror Added a |
Similar to the `wait_agent_condition` function, only it does not require to be executed on an agent.
Hopefully prevents this from happening again:
https://travis-ci.org/opensistemas-hub/osbrain/jobs/341672571