Skip to content

Safer one-way kill in close IPC socket test#251

Merged
Peque merged 2 commits intoopensistemas-hub:masterfrom
Peque:kill
Feb 26, 2018
Merged

Safer one-way kill in close IPC socket test#251
Peque merged 2 commits intoopensistemas-hub:masterfrom
Peque:kill

Conversation

@Peque
Copy link
Copy Markdown
Member

@Peque Peque commented Feb 15, 2018

Hopefully prevents this from happening again:

https://travis-ci.org/opensistemas-hub/osbrain/jobs/341672571

@Peque Peque added this to the 0.7.0 milestone Feb 15, 2018
@Peque Peque self-assigned this Feb 15, 2018
@Peque Peque requested a review from ocaballeror February 15, 2018 10:12
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 15, 2018

Codecov Report

Merging #251 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
+ Coverage   99.08%   99.08%   +<.01%     
==========================================
  Files          26       26              
  Lines        3481     3503      +22     
  Branches      250      251       +1     
==========================================
+ Hits         3449     3471      +22     
  Misses         20       20              
  Partials       12       12
Impacted Files Coverage Δ
osbrain/helper.py 100% <100%> (ø) ⬆️
osbrain/tests/test_agent_ipc_sockets.py 100% <100%> (ø) ⬆️
osbrain/tests/test_helper.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e3e96a...4446b16. Read the comment docs.

Copy link
Copy Markdown
Contributor

@ocaballeror ocaballeror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
We should also probably change some of the other tests to use this function instead of arbitrary time.sleep() delays.

@Peque
Copy link
Copy Markdown
Member Author

Peque commented Feb 16, 2018

@ocaballeror Yeah, I bet there are a couple of tests that could benefit from this. I'll implement the "negated wait_condition()" too in that case and ask you for review again. We can then open a ticket to have a look at where we could use this function.

@Peque Peque requested a review from ocaballeror February 16, 2018 10:59
@Peque
Copy link
Copy Markdown
Member Author

Peque commented Feb 16, 2018

@ocaballeror Added a negate parameter, which should be useful if we integrate the use of this function in other tests in the near future.

Similar to the `wait_agent_condition` function, only it does not require
to be executed on an agent.
@Peque Peque merged commit 4446b16 into opensistemas-hub:master Feb 26, 2018
@Peque Peque deleted the kill branch February 26, 2018 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants