Skip to content

Do not use IPC by default for Windows systems#146

Closed
Peque wants to merge 1 commit intoopensistemas-hub:masterfrom
Peque:windows
Closed

Do not use IPC by default for Windows systems#146
Peque wants to merge 1 commit intoopensistemas-hub:masterfrom
Peque:windows

Conversation

@Peque
Copy link
Member

@Peque Peque commented Jun 20, 2017

@Flood1993 Can you try to run the tests on Windows?

I'll try to set up AppVeyor.

@Peque Peque added this to the 1.0.0 milestone Jun 20, 2017
@Peque Peque self-assigned this Jun 20, 2017
@Peque Peque requested a review from Flood1993 June 20, 2017 08:11
Flood1993
Flood1993 approved these changes Jun 20, 2017
View reviewed changes
Copy link
Member

@Flood1993 Flood1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for me on Windows, even though tests that explicitly use IPC will need to be skipped. I will create a new issue for that

@Peque Peque force-pushed the windows branch 13 times, most recently from 0f2bed3 to 3dfe1a1 Compare June 20, 2017 10:44
@Peque Peque mentioned this pull request Jun 20, 2017
Closed
@opensistemas-hub opensistemas-hub deleted a comment from codecov bot Jul 13, 2017
@Peque
Copy link
Member Author

Peque commented Jul 13, 2017

@Flood1993 Maybe you could rebase your #147 onto this PR?

@codecov
Copy link

codecov bot commented Jul 19, 2017 •
edited
Loading

Codecov Report

Merging #146 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   98.87%   98.87%           
=======================================
  Files          25       25           
  Lines        3189     3189           
  Branches      241      241           
=======================================
  Hits         3153     3153           
  Misses         24       24           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b72783...df5333e. Read the comment docs.

@Flood1993
Copy link
Member

Flood1993 commented Jul 24, 2017

Rebased #147 (not squashed)

@Peque Peque mentioned this pull request Sep 1, 2017
Closed
@Peque Peque removed this from the 1.0.0 milestone Feb 5, 2018
@Peque Peque added this to the 0.7.0 milestone Feb 5, 2018
@Peque
Copy link
Member Author

Peque commented Feb 27, 2018

Closed in favor of #252.

@Peque Peque closed this Feb 27, 2018
@Peque Peque deleted the windows branch March 23, 2018 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Flood1993 Flood1993 Flood1993 approved these changes

Assignees

@Peque Peque

@ocaballeror ocaballeror

Labels

enhancement

Projects

None yet

Milestone

0.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Peque @Flood1993 @ocaballeror