[build] Use golang 1.13 for builder - #7
Merged
Merged
Conversation
openshift-ci-robot
added
the
size/S
Contributor
Author
|
/cc @openshift/openshift-team-windows-containers |
|
@aravindhp WORKDIR location is also changed from $HOME/build to /build. Please update your commit message to reflect so, otherwise lgtm |
The operator requires golang 1.13 for building. Remove the hack that required us to $HOME/build/ as we are changing build images. Though to be accurate, the issue had nothing to do with the image but with podman-container-tools/buildah#2189.
aravindhp
force-pushed
the
dockerfile-ci-go.1.13
branch
from
February 27, 2020 20:30
b412d9e to
e218a26
Compare
Contributor
|
/lgtm |
Contributor
Author
Fixed |
Contributor
|
/lgtm |
wgahnagl
pushed a commit
to wgahnagl/windows-machine-config-operator
that referenced
this pull request
Mar 6, 2023
[git] modify gitignore to exclude IDE settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The operator requires golang 1.13 for building. Remove the hack that required us to $HOME/build/ as we are changing build images. Though to be accurate, the issue had nothing to do with the image but with podman-container-tools/buildah#2189.