Update .gitignore for GoLand - #2
Merged
Merged
Conversation
Contributor
Author
|
/cc @openshift/openshift-team-windows-containers |
openshift-ci-robot
added
the
size/XS
sebsoto
reviewed
Feb 20, 2020
|
|
||
| # Directory of IDE settings | ||
| *.idea/* | ||
| *.vscode/* |
Contributor
There was a problem hiding this comment.
From git ignore docs:
The pattern foo/ will match a directory foo and paths underneath it, but will not match a regular file or a symbolic link foo (this is consistent with the way how pathspec works in general in Git)
Do you need the trailing *?
Especially since:
The pattern "foo/*", matches "foo/test.json" (a regular file), "foo/bar" (a directory), but it does not match "foo/bar/hello.c" (a regular file), as the asterisk in the pattern does not match "bar/hello.c" which has a slash in it.
Contributor
Author
There was a problem hiding this comment.
I copied it over from the WMCB repo. We should fix it there too.
Contributor
|
/lgtm |
Add GoLand config directory to .gitignore
Contributor
|
/approve |
|
/lgtm |
alinaryan
added a commit
to alinaryan/windows-machine-config-operator
that referenced
this pull request
Apr 8, 2021
# This is the 1st commit message: [ci] Add logs to network tests The purpose of this commit is to add pod logs to our networking tests to aid in seeing the network communication errors. # This is the commit message openshift#2: [ci] adjust job name
wgahnagl
pushed a commit
to wgahnagl/windows-machine-config-operator
that referenced
this pull request
Mar 6, 2023
Introduce contribution guidelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GoLand config directory to .gitignore