Replace manual disk cleanup with quick-cleanup#471
Replace manual disk cleanup with quick-cleanup#471sebrandon1 wants to merge 1 commit intoopenshift:oadp-devfrom
Conversation
Consolidates manual disk cleanup into a shared, maintained action that also provides automatic Docker storage relocation to /mnt.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sebrandon1 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughGitHub Actions workflow updated in the push.yml file to refactor disk space cleanup operations. A new dedicated step using the palmsoftware/quick-cleanup action was added to run before container image publishing, and three explicit cleanup commands were removed from the "Publish container image" step. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/push.yml:
- Around line 54-58: Update the GitHub Actions step named "Free up disk space"
to pin the action reference to the immutable commit SHA instead of the mutable
tag; replace uses: palmsoftware/quick-cleanup@v0 with uses:
palmsoftware/quick-cleanup@21be80c22ed5745594aa5ca6350089499d54db4b and keep the
original `@v0` tag as a commented note for traceability, leaving the step name and
inputs (cleanup-mode: aggressive) unchanged.
| - name: Free up disk space | ||
| if: github.repository == 'vmware-tanzu/velero' | ||
| uses: palmsoftware/quick-cleanup@v0 | ||
| with: | ||
| cleanup-mode: aggressive |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Resolve the current commit behind the v0 tag
git ls-remote https://github.com/palmsoftware/quick-cleanup.git refs/tags/v0Repository: openshift/velero
Length of output: 113
Pin palmsoftware/quick-cleanup to a commit SHA.
Using a mutable tag (@v0) weakens supply-chain integrity. Pin to the specific commit SHA (21be80c22ed5745594aa5ca6350089499d54db4b) and keep the tag as a comment for traceability.
🔒 Proposed change
- uses: palmsoftware/quick-cleanup@v0
+ # v0
+ uses: palmsoftware/quick-cleanup@21be80c22ed5745594aa5ca6350089499d54db4b📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: Free up disk space | |
| if: github.repository == 'vmware-tanzu/velero' | |
| uses: palmsoftware/quick-cleanup@v0 | |
| with: | |
| cleanup-mode: aggressive | |
| - name: Free up disk space | |
| if: github.repository == 'vmware-tanzu/velero' | |
| # v0 | |
| uses: palmsoftware/quick-cleanup@21be80c22ed5745594aa5ca6350089499d54db4b | |
| with: | |
| cleanup-mode: aggressive |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/push.yml around lines 54 - 58, Update the GitHub Actions
step named "Free up disk space" to pin the action reference to the immutable
commit SHA instead of the mutable tag; replace uses:
palmsoftware/quick-cleanup@v0 with uses:
palmsoftware/quick-cleanup@21be80c22ed5745594aa5ca6350089499d54db4b and keep the
original `@v0` tag as a commented note for traceability, leaving the step name and
inputs (cleanup-mode: aggressive) unchanged.
|
Closing — GitHub Actions is not enabled on this fork (only Dependabot dependency graph updates run here). The upstream workflows are not executed in this repo. |
Summary
Replace manual disk cleanup scripts with the shared
palmsoftware/quick-cleanupGitHub Action.This consolidates the manual cleanup (swapoff, swap removal, docker system prune) into a single maintained action as a separate step before the publish step. It also provides automatic Docker storage relocation to the larger
/mntpartition.Already in use
quick-cleanupis already adopted in production workflows across multiple repos:crc-org/crc— CRC (OpenShift Local)palmsoftware/quick-ocp— OpenShift cluster deployment actionpalmsoftware/quick-k8s— Kubernetes cluster deployment action (KinD/Minikube)Related PRs
Tracking
Changes
.github/workflows/push.yml— extracted cleanup into separatepalmsoftware/quick-cleanup@v0stepBenefits
/mnt(larger partition)df -houtput