Add metrics gathering for console_url#239
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Sep 20, 2019
Merged
Add metrics gathering for console_url#239openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/XS
benjaminapetersen
force-pushed
the
console/console_url
branch
from
091b46c to
737c0bd
Compare
Contributor
Author
|
@spadgett fyi |
Member
Contributor
|
/lgtm Once #240 this should get a lgtm label, if prow is clever enough :) |
Contributor
Author
|
|
smarterclayton
added
the
approved
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: benjaminapetersen, LiliC The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
console_urlto whitelist following this PR:For reference:
jsonnet/telemeter/metrics.jsonnetMAKE=make make generate-in-dockerto generate docs./assign @brancz @lilic