Skip to content

Conversation

@crawford
Copy link
Contributor

@crawford crawford commented Aug 5, 2019

This series will allow us to determine whether a cluster was created
using IPI or UPI. Once Hive and CI are updated, we'll also be able to
determine if a cluster was created by CI or if it was created by Hive.

The series captures the install type, the version of the tool, and its
invoker (in addition to the standard labels):

cluster_installer{
    type="openshift-install",
    version="unreleased-master-1209-gfd08f44181f2111",
    invoker="user",
} 0 1562168623759

This is a backport of #189.

@openshift-ci-robot
Copy link
Contributor

@crawford: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

metrics: gather cluster_installer series

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 5, 2019
@s-urbaniak
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 5, 2019
@crawford
Copy link
Contributor Author

crawford commented Aug 5, 2019

The release architects have agreed that there is no need for a valid Bugzilla for this particular backport due to it being purely telemetry-focused and because QE isn't able to verify.

@crawford crawford added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 5, 2019
This series will allow us to determine whether a cluster was created
using IPI or UPI. Once Hive and CI are updated, we'll also be able to
determine if a cluster was created by CI or if it was created by Hive.

The series captures the install type, the version of the tool, and its
invoker (in addition to the standard labels):

    cluster_installer{
        type="openshift-install",
        version="unreleased-master-1209-gfd08f44181f2111",
        invoker="user",
    } 0 1562168623759
This new sample includes the new cluster_installer series.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2019
@s-urbaniak
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8c708d1 into openshift:release-4.1 Aug 5, 2019
@crawford crawford deleted the cluster_installer branch August 5, 2019 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants