feat: added leader election conventons#601
feat: added leader election conventons#601eggfoobar wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eggfoobar The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
updated leader eleciton to follow convention and use SNO topology aware methods updated openshift/client-go and openshift/api updated controller runtime ran: go mod tidy && go mod vendor Signed-off-by: ehila <ehila@redhat.com> bump: controller-runtime to support k8s 0.22.1 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
force-pushed
the
leader_election_config
branch
from
e6a9537 to
0c5591d
Compare
|
@eggfoobar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/assign SchSeba |
|
@eggfoobar Thanks for your PR. We have an upstream project at https://github.com/k8snetworkplumbingwg/sriov-network-operator. Could you propose the change there? |
|
+1 please open the PR on the u/s repo so we can have a discussion there. |
|
Sure thing |
…vars move namespace to vars pkg
3 participants
This should take advantage of leader election changes for SNO clusters proposed in this library-go PR.
Changes:
ran:
go mod tidy && go mod vendor
Signed-off-by: ehila ehila@redhat.com