Add support for .sti/environment file #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
fyi, this works for both ONBUILD and STI strategies |
Contributor
|
LGTM |
README.md
Outdated
Contributor
There was a problem hiding this comment.
make it clear these env variables also end up existing in the output image.
Contributor
Author
|
@bparees fixed. the layered build will get the env vars same way as regular STI build. I was looking at stdlib for property file parser, but found nothing (I found some 3th party libs, but I think they are overkill for this) |
Contributor
Author
|
[test] |
Contributor
|
Source To Image Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_sti/74/) |
Contributor
|
lgtm. [merge] |
Contributor
|
Source To Image Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_sti/69/) |
Contributor
|
Evaluated for source to image up to d2e8a46 |
openshift-bot
pushed a commit
that referenced
this pull request
Feb 24, 2015
Merged by openshift-bot
This was referenced Feb 25, 2015
sayan-biswas
pushed a commit
to sayan-biswas/openshift-source-to-image
that referenced
this pull request
Jan 21, 2025
OCPBUGS-21730: bump golang.org/x/net to v0.17.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.