Card devexp_426 - Renaming Clean to Incremental to better match current behaviour, where Incremental needs to be forced #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt behaviour, where Incremental needs to be forced
Contributor
|
@soltysh LGTM, it makes more sense to me now as the 'clean' is now always true. |
Contributor
|
+1 [merge] |
Contributor
|
Source To Image Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_sti/67/) |
Contributor
|
Evaluated for source to image up to 4cfdc51 |
openshift-bot
pushed a commit
that referenced
this pull request
Feb 23, 2015
Merged by openshift-bot
sayan-biswas
pushed a commit
to sayan-biswas/openshift-source-to-image
that referenced
this pull request
Jan 21, 2025
…penshift-4.15-ose-csi-driver-shared-resource-webhook OCPBUGS-19155: Updating ose-csi-driver-shared-resource-webhook images to be consistent with ART
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After talking to @mfojtik we've decided to rename the
Cleanvariable toIncrementalto better match current behavior. This came up when doing openshift/origin#1101./cc @bparees