-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUILD-1190: Add FIPS compliance #1200
Conversation
@sayan-biswas: This pull request references BUILD-1190 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "s2i-1.5" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
380ab5a
to
5dfc871
Compare
@sayan-biswas: This pull request references BUILD-1190 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "s2i-1.5" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
221130c
to
52ceb81
Compare
/test "ci/prow/verify" |
@sayan-biswas: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test verify |
@sayan-biswas: Overrode contexts on behalf of sayan-biswas: Red Hat Konflux / source-to-image-enterprise-contract / source-to-image In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test verify |
@sayan-biswas: This pull request references BUILD-1190 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.19." or "openshift-4.19.", but it targets "s2i-1.5" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Changes: - Update Go to 1.22 - Update Dockerfile for FIPS compliance - Disable btrfs to prevent build error due to missing library btrfs/ioct.h
@sayan-biswas: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
EC check fails because of |
/override "Red Hat Konflux / source-to-image-enterprise-contract / source-to-image" |
@sayan-biswas: Overrode contexts on behalf of sayan-biswas: Red Hat Konflux / source-to-image-enterprise-contract / source-to-image In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
- linux/ppc64le | ||
- linux/s390x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit for follow-up - we don't need to build for power + z on pull requests.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, sayan-biswas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
156e942
into
openshift:master
Changes: