Skip to content

Set eusc-techpreview jobs to candidate tier#3383

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
yunjiang29:update-aws-eusc-tp-tier
Mar 31, 2026
Merged

Set eusc-techpreview jobs to candidate tier#3383
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
yunjiang29:update-aws-eusc-tp-tier

Conversation

@yunjiang29
Copy link
Copy Markdown
Contributor

@yunjiang29 yunjiang29 commented Mar 30, 2026

Add pattern to classify jobs with "-eusc-techpreview" suffix as candidate tier. This allows these techpreview jobs to be tracked in Sippy while they stabilize before being promoted to standard tier.

This will affect custom DNS techpreview jobs:

e2e-aws-eusc-techpreview

which are being added in openshift/release#75568

Summary by CodeRabbit

  • New Features
    • Added classification support for EUSC techpreview jobs, assigning them to the candidate tier in the job matching system.

Add pattern to classify jobs with "-eusc-techpreview" suffix
as candidate tier. This allows these techpreview jobs to be tracked
in Sippy while they stabilize before being promoted to standard tier.
@openshift-ci-robot
Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci bot requested review from dgoodwin and neisw March 30, 2026 02:56
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 4a23b82b-339c-414e-bb6c-fcdf2729badf

📥 Commits

Reviewing files that changed from the base of the PR and between 181133a and e3ec847.

📒 Files selected for processing (1)
  • pkg/variantregistry/ocp.go

Walkthrough

A new job tier matching rule was added to classify job names containing -eusc-techpreview as "candidate" tier. This extends the existing ordered tier pattern matching list used for variant registry job classification.

Changes

Cohort / File(s) Summary
EUSC Techpreview Job Tier Classification
pkg/variantregistry/ocp.go
Added setJobTier matching rule to assign -eusc-techpreview jobs to the "candidate" variant tier, inserted before subsequent default candidate-matching patterns.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Go Error Handling ✅ Passed The PR only adds a data structure entry without error handling patterns, panic calls, or pointer dereferences.
Sql Injection Prevention ✅ Passed The PR adds a hardcoded string pattern to an in-memory job tier classification function with no SQL operations, user input handling, or query construction involved.
Excessive Css In React Should Use Styles ✅ Passed This custom check is not applicable to the pull request. The PR modifies only pkg/variantregistry/ocp.go, a Go backend file that implements job tier classification logic for Sippy. The file contains no React components, JSX, inline CSS styles, or any styling code whatsoever.
Single Responsibility And Clear Naming ✅ Passed The PR adheres to Single Responsibility and Clear Naming guidelines with minimal, focused changes that maintain established architectural patterns.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link
Copy Markdown

Scheduling required tests:
/test e2e

@yunjiang29
Copy link
Copy Markdown
Contributor Author

@gpei @jianlinliu @liweinan @tthvo PATL

@gpei
Copy link
Copy Markdown
Contributor

gpei commented Mar 30, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2026
@liweinan
Copy link
Copy Markdown

/lgtm /approve

@yunjiang29
Copy link
Copy Markdown
Contributor Author

@neisw Can you review and approve this PR? Thanks

@neisw
Copy link
Copy Markdown
Contributor

neisw commented Mar 31, 2026

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gpei, liweinan, neisw, yunjiang29

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2026
@tthvo
Copy link
Copy Markdown
Member

tthvo commented Mar 31, 2026

/tide refresh

@openshift-ci-robot
Copy link
Copy Markdown

Scheduling required tests:
/test e2e

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

@yunjiang29: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 38d3cba into openshift:main Mar 31, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants