Skip to content

Conversation

@marun
Copy link
Contributor

@marun marun commented Nov 12, 2019

This ensures that the CRD is compatible with oc explain.

This ensures that the CRD is compatible with `oc explain`.
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 12, 2019
@openshift-ci-robot
Copy link
Contributor

@marun: This pull request references Bugzilla bug 1769793, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1769793: Use openshift/api vendored config CRD

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 12, 2019
@marun
Copy link
Contributor Author

marun commented Nov 12, 2019

/retest

2 similar comments
@marun
Copy link
Contributor Author

marun commented Nov 13, 2019

/retest

@marun
Copy link
Contributor Author

marun commented Nov 14, 2019

/retest

@stlaz
Copy link
Contributor

stlaz commented Nov 18, 2019

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2019
@openshift-merge-robot openshift-merge-robot merged commit e3eb0b3 into openshift:master Nov 18, 2019
@openshift-ci-robot
Copy link
Contributor

@marun: All pull requests linked via external trackers have merged. Bugzilla bug 1769793 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1769793: Use openshift/api vendored config CRD

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants