Bug 2034484: feat: library-go bump by qJkee · Pull Request #185 · openshift/service-ca-operator

qJkee · 2021-12-09T15:30:12Z

Bumping the library-go dependency to latest, this should take advantage of leader election changes for SNO clusters proposed in this library-go PR and performance improvements in this PR.

It also includes the following BZ bug fix
Bug 2034484: fix:library-go nil pointer issue

qJkee · 2021-12-09T16:51:23Z

/retest

stlaz · 2021-12-14T10:45:09Z

Please move any changes done outside the vendoring to a separate commit.

qJkee · 2021-12-15T15:05:06Z

/retest-required

jerpeter1 · 2021-12-15T21:57:49Z

/retest-required

jerpeter1 · 2021-12-15T22:15:56Z

/retest-required

jerpeter1 · 2021-12-15T22:59:34Z

/test e2e-aws-operator

jerpeter1 · 2021-12-15T23:24:53Z

/test e2e-aws-operator

jerpeter1 · 2021-12-15T23:29:50Z

/test e2e-aws-operator

jerpeter1 · 2021-12-16T12:43:25Z

/test e2e-aws-operator

jerpeter1 · 2021-12-16T13:04:25Z

/test e2e-aws-operator

jerpeter1 · 2021-12-16T13:24:06Z

/test e2e-aws-operator

qJkee · 2021-12-21T16:32:23Z

/retest-required

jerpeter1 · 2021-12-22T14:30:37Z

/retest-required

stlaz

please separate the changes to separate commits and explain them

stlaz · 2021-12-23T08:06:51Z

+- apiGroups:
+  - config.openshift.io
+  resources:
+  - infrastructures
+  verbs:
+  - get
+  - list
+  - watch


separate commit, explain in commit message please

stlaz · 2021-12-23T08:07:39Z

 	pflag.CommandLine.SetNormalizeFunc(utilflag.WordSepNormalizeFunc)
 	pflag.CommandLine.AddGoFlagSet(goflag.CommandLine)

+	logs.AddFlags(pflag.CommandLine)


separate commit, fix like this: openshift/cluster-authentication-operator@a2f0d1f

stlaz · 2021-12-23T08:08:01Z


 func (c serviceCAOperator) updateStatus(operatorConfig *operatorv1.ServiceCA) {
-	v1helpers.UpdateStatus(c.operatorClient, func(status *operatorv1.OperatorStatus) error {
+	v1helpers.UpdateStatus(context.TODO(), c.operatorClient, func(status *operatorv1.OperatorStatus) error {


wire the context properly

… election

openshift-ci · 2021-12-24T10:34:34Z

@qJkee: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

stlaz · 2022-01-03T08:41:44Z

/lgtm
thank you for your PR 👍

openshift-ci · 2022-01-03T08:41:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qJkee, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [stlaz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ggiguash · 2022-01-03T17:30:40Z

/retitle Bug 2034484: feat: library-go bump

openshift-ci · 2022-01-03T17:30:47Z

@qJkee: This pull request references Bugzilla bug 2034484, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (jhou@redhat.com), skipping review request.

Details

In response to this:

Bug 2034484: feat: library-go bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-01-03T17:32:20Z

@qJkee: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/cluster-authentication-operator#525 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2034484 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 2034484: feat: library-go bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-05-01T14:35:52Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-service-ca-operator-container-v4.10.0-202305011254.p0.g1611373.assembly.stream for distgit ose-service-ca-operator.
All builds following this will include this PR.

openshift-ci Bot requested review from deads2k and stlaz December 9, 2021 15:46

qJkee changed the title ~~Upgrade library-go version~~ WIP:Upgrade library-go version Dec 9, 2021

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2021

qJkee marked this pull request as draft December 9, 2021 17:35

qJkee marked this pull request as ready for review December 13, 2021 18:38

qJkee changed the title ~~WIP:Upgrade library-go version~~ [WIP] Upgrade library-go version Dec 13, 2021

qJkee force-pushed the CNF-3684-deps branch from 3f0678f to 8979873 Compare December 13, 2021 18:58

qJkee force-pushed the CNF-3684-deps branch 2 times, most recently from bf654f7 to 9d3bf6a Compare December 14, 2021 20:39

qJkee force-pushed the CNF-3684-deps branch from 9d3bf6a to 2f29da7 Compare December 15, 2021 18:53

qJkee force-pushed the CNF-3684-deps branch 2 times, most recently from 5415c57 to 6d8927a Compare December 17, 2021 16:33

upgrade library-go version

9fcd15a

qJkee force-pushed the CNF-3684-deps branch 3 times, most recently from 9465f82 to d1a7d50 Compare December 21, 2021 14:27

qJkee changed the title ~~[WIP] Upgrade library-go version~~ Upgrade library-go version Dec 22, 2021

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 22, 2021

stlaz suggested changes Dec 23, 2021

View reviewed changes

qJkee added 3 commits December 24, 2021 03:28

bump library-go: pass ctx corectly to update functions

bb03417

kube-bump: update cli entrypoint to new way

85ccd9a

library-go: add infrastructures to cluster role for new lib-go leader…

89f04d8

… election

qJkee force-pushed the CNF-3684-deps branch from d1a7d50 to 89f04d8 Compare December 24, 2021 08:49

stlaz approved these changes Jan 3, 2022

View reviewed changes

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2022

openshift-ci Bot assigned stlaz Jan 3, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2022

openshift-ci Bot changed the title ~~Upgrade library-go version~~ Bug 2034484: feat: library-go bump Jan 3, 2022

openshift-ci Bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jan 3, 2022

openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 3, 2022

openshift-merge-robot merged commit 1611373 into openshift:master Jan 3, 2022

Conversation

qJkee commented Dec 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qJkee commented Dec 9, 2021

Uh oh!

stlaz commented Dec 14, 2021

Uh oh!

qJkee commented Dec 15, 2021

Uh oh!

jerpeter1 commented Dec 15, 2021

Uh oh!

jerpeter1 commented Dec 15, 2021

Uh oh!

jerpeter1 commented Dec 15, 2021

Uh oh!

jerpeter1 commented Dec 15, 2021

Uh oh!

jerpeter1 commented Dec 15, 2021

Uh oh!

jerpeter1 commented Dec 16, 2021

Uh oh!

jerpeter1 commented Dec 16, 2021

Uh oh!

jerpeter1 commented Dec 16, 2021

Uh oh!

qJkee commented Dec 21, 2021

Uh oh!

jerpeter1 commented Dec 22, 2021

Uh oh!

stlaz left a comment

Choose a reason for hiding this comment

Uh oh!

stlaz Dec 23, 2021

Choose a reason for hiding this comment

Uh oh!

qJkee Dec 27, 2021

Choose a reason for hiding this comment

Uh oh!

stlaz Dec 23, 2021

Choose a reason for hiding this comment

Uh oh!

qJkee Dec 27, 2021

Choose a reason for hiding this comment

Uh oh!

stlaz Dec 23, 2021

Choose a reason for hiding this comment

Uh oh!

qJkee Dec 27, 2021

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Dec 24, 2021

Uh oh!

stlaz commented Jan 3, 2022

Uh oh!

openshift-ci Bot commented Jan 3, 2022

Uh oh!

ggiguash commented Jan 3, 2022

Uh oh!

openshift-ci Bot commented Jan 3, 2022

Uh oh!

openshift-ci Bot commented Jan 3, 2022

Uh oh!

openshift-bot commented May 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

qJkee commented Dec 9, 2021 •

edited

Loading